Fix CI issues for MySQL and MSSQL

- MySQL: Don't include -p flag when password is empty
- MSSQL: Use mssql-tools18 path with -C flag for newer images

Author: gfx

.github/workflows/example.yaml

@@ -142,14 +142,17 @@ jobs:
 
           # Wait for MSSQL to be ready
           for i in {1..60}; do
-            if docker exec $(docker compose ps -q mssql) /opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P "Passw0rd" -Q "SELECT 1" >/dev/null 2>&1; then
+            # Try both old and new sqlcmd paths for compatibility
+            if docker exec $(docker compose ps -q mssql) /opt/mssql-tools18/bin/sqlcmd -S localhost -U SA -P "Passw0rd" -Q "SELECT 1" -C >/dev/null 2>&1 || \
+               docker exec $(docker compose ps -q mssql) /opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P "Passw0rd" -Q "SELECT 1" >/dev/null 2>&1; then
               echo "MSSQL is ready"
               break
             fi
             echo "Waiting for MSSQL..."
             sleep 3
           done
-          # Create the test database
+          # Create the test database (try both paths)
+          docker exec $(docker compose ps -q mssql) /opt/mssql-tools18/bin/sqlcmd -S localhost -U SA -P "Passw0rd" -Q "CREATE DATABASE testdb;" -C || \
           docker exec $(docker compose ps -q mssql) /opt/mssql-tools/bin/sqlcmd -S localhost -U SA -P "Passw0rd" -Q "CREATE DATABASE testdb;"
 
       - name: Preview MSSQL schema changes

dist/index.js

@@ -126,9 +126,11 @@ function getCommandConfig(command) {
             config.args.push("-h", host, "-P", port);
             if (user)
                 config.args.push("-u", user);
-            // Always include -p with the password value (even if empty)
-            // mysqldef accepts -p with empty string for passwordless connections
-            config.args.push(`-p${password}`);
+            // Only include -p if password is not empty
+            // Empty password means no authentication needed
+            if (password && password.trim() !== "") {
+                config.args.push(`-p${password}`);
+            }
             if (database)
                 config.args.push(database);
             break;

dist/index.js.map

@@ -100,9 +100,11 @@ function getCommandConfig(command: string): CommandConfig {
 
             config.args.push("-h", host, "-P", port);
             if (user) config.args.push("-u", user);
-            // Always include -p with the password value (even if empty)
-            // mysqldef accepts -p with empty string for passwordless connections
-            config.args.push(`-p${password}`);
+            // Only include -p if password is not empty
+            // Empty password means no authentication needed
+            if (password && password.trim() !== "") {
+                config.args.push(`-p${password}`);
+            }
             if (database) config.args.push(database);
             break;
         }