Skip to content

Commit fbee0c1

Browse files
author
Daniele Briggi
committed
chore(windows): detecting fix for make test
1 parent 871c19a commit fbee0c1

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ jobs:
5757
install: >-
5858
mingw-w64-x86_64-cc
5959
mingw-w64-x86_64-cmake
60-
mingw-w64-x86_64-toolchain
6160
make
6261
6362
- name: linux install dependencies

Makefile

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ MAKEFLAGS += -j$(CPUS)
2828
CC = gcc
2929
CXX = g++
3030
CFLAGS = -Wall -Wextra -Wno-unused-parameter -I$(SRC_DIR) -I$(LLAMA_DIR)/ggml/include -I$(LLAMA_DIR)/include
31-
CXXFLAGS =
3231
LDFLAGS = -L./$(BUILD_LLAMA)/common -L./$(BUILD_LLAMA)/ggml/src -L./$(BUILD_LLAMA)/src -L./$(BUILD_WHISPER)/src -lcommon -lggml -lggml-cpu -lggml-base -lllama -lwhisper
3332
LLAMA_OPTIONS = $(LLAMA) -DLLAMA_CURL=OFF -DLLAMA_BUILD_EXAMPLES=OFF -DLLAMA_BUILD_TESTS=OFF -DLLAMA_BUILD_TOOLS=OFF -DLLAMA_BUILD_SERVER=OFF
3433
WHISPER_OPTIONS = $(WHISPER) -DWHISPER_BUILD_EXAMPLES=OFF -DWHISPER_BUILD_TESTS=OFF -DWHISPER_BUILD_SERVER=OFF
@@ -56,12 +55,6 @@ ifeq ($(PLATFORM),windows)
5655
# Create .def file for Windows
5756
DEF_FILE := $(BUILD_DIR)/ai.def
5857
STRIP = strip --strip-unneeded $@
59-
# Windows-specific C++ flags to work around MinGW codecvt issues
60-
# CXXFLAGS += -D_GLIBCXX_USE_CXX11_ABI=1 -DGGML_USE_UNICODE=0 -DLLAMA_DISABLE_UNICODE=1
61-
CXXFLAGS += -std=c++17 -Wall -Wextra -Wno-unused-parameter -I$(SRC_DIR) -I$(LLAMA_DIR)/ggml/include -I$(LLAMA_DIR)/include
62-
# Windows-specific flags to work around MinGW codecvt issues
63-
# LLAMA_OPTIONS += -DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_FLAGS="-D_GLIBCXX_USE_CXX11_ABI=1 -DGGML_USE_UNICODE=0 -DLLAMA_DISABLE_UNICODE=1"
64-
# WHISPER_OPTIONS += -DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_FLAGS="-D_GLIBCXX_USE_CXX11_ABI=1 -DGGML_USE_UNICODE=0"
6558
else ifeq ($(PLATFORM),macos)
6659
TARGET := $(DIST_DIR)/ai.dylib
6760
LLAMA_LIBS += $(BUILD_LLAMA)/ggml/src/ggml-metal/libggml-metal.a $(BUILD_LLAMA)/ggml/src/ggml-blas/libggml-blas.a
@@ -139,7 +132,7 @@ all: $(TARGET)
139132

140133
# Loadable library
141134
$(TARGET): $(OBJ_FILES) $(DEF_FILE) $(LLAMA_LIBS) $(WHISPER_LIBS)
142-
$(CXX) $(CXXFLAGS) $(OBJ_FILES) $(DEF_FILE) -o $@ $(LDFLAGS)
135+
$(CXX) $(OBJ_FILES) $(DEF_FILE) -o $@ $(LDFLAGS)
143136
ifeq ($(PLATFORM),windows)
144137
# Generate import library for Windows
145138
dlltool -D $@ -d $(DEF_FILE) -l $(DIST_DIR)/ai.lib

0 commit comments

Comments
 (0)