chore(tests): add cli tests

Author: Daniele Briggi

src/sqlite_rag/cli.py

@@ -257,14 +257,19 @@ def add(
     rag_context = ctx.obj["rag_context"]
     start_time = time.time()
 
-    # Parse and normalize extension lists
     only_list = (
         [e.strip().lstrip(".").lower() for e in only_extensions.split(",") if e.strip()]
-        if only_extensions else None
+        if only_extensions
+        else None
     )
     exclude_list = (
-        [e.strip().lstrip(".").lower() for e in exclude_extensions.split(",") if e.strip()]
-        if exclude_extensions else None
+        [
+            e.strip().lstrip(".").lower()
+            for e in exclude_extensions.split(",")
+            if e.strip()
+        ]
+        if exclude_extensions
+        else None
     )
 
     rag = rag_context.get_rag()

src/sqlite_rag/reader.py

@@ -46,7 +46,13 @@ def is_supported(
         only_extensions: Optional[list[str]] = None,
         exclude_extensions: Optional[list[str]] = None,
     ) -> bool:
-        """Check if the file extension is supported"""
+        """Check if the file extension is supported.
+
+        Parameters:
+            path (Path): The file path to check.
+            only_extensions (Optional[list[str]]): If provided, only files with these extensions are considered.
+            exclude_extensions (Optional[list[str]]): If provided, files with these extensions are excluded.
+        """
         extension = path.suffix.lower().lstrip(".")
 
         supported_extensions = set(FileReader.extensions)

tests/integration/test_cli.py

@@ -113,3 +113,86 @@ def test_change_database_path(self):
             assert result.exit_code == 0
 
             assert f"Database: {tmp_db.name}" in result.stdout
+
+    def test_add_with_exclude_extensions(self):
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            (Path(tmp_dir) / "file1.txt").write_text("This is a text file.")
+            (Path(tmp_dir) / "file2.md").write_text("# This is a markdown file.")
+            (Path(tmp_dir) / "file3.py").write_text("print('Hello, world!')")
+            (Path(tmp_dir) / "file4.js").write_text("console.log('Hello, world!');")
+
+            with tempfile.NamedTemporaryFile(suffix=".tempdb") as tmp_db:
+                runner = CliRunner()
+
+                result = runner.invoke(
+                    app,
+                    ["--database", tmp_db.name, "add", tmp_dir, "--exclude", "py,js"],
+                )
+                assert result.exit_code == 0
+
+                # Check that only .txt and .md files were added
+                assert "Processing 2 files" in result.stdout
+                assert "file1.txt" in result.stdout
+                assert "file2.md" in result.stdout
+                assert "file3.py" not in result.stdout
+                assert "file4.js" not in result.stdout
+
+    def test_add_with_only_extensions(self):
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            (Path(tmp_dir) / "file1.txt").write_text("This is a text file.")
+            (Path(tmp_dir) / "file2.md").write_text("# This is a markdown file.")
+            (Path(tmp_dir) / "file3.py").write_text("print('Hello, world!')")
+            (Path(tmp_dir) / "file4.js").write_text("console.log('Hello, world!');")
+
+            with tempfile.NamedTemporaryFile(suffix=".tempdb") as tmp_db:
+                runner = CliRunner()
+
+                result = runner.invoke(
+                    app,
+                    [
+                        "--database",
+                        tmp_db.name,
+                        "add",
+                        tmp_dir,
+                        "--only",
+                        "md,txt",
+                    ],
+                )
+                assert result.exit_code == 0
+
+                # Check that only .txt and .md files were added
+                assert "Processing 2 files" in result.stdout
+                assert "file1.txt" in result.stdout
+                assert "file2.md" in result.stdout
+                assert "file3.py" not in result.stdout
+                assert "file4.js" not in result.stdout
+
+    def test_add_with_only_and_exclude_extensions_are_normilized(self):
+        with tempfile.TemporaryDirectory() as tmp_dir:
+            (Path(tmp_dir) / "file1.txt").write_text("This is a text file.")
+            (Path(tmp_dir) / "file2.md").write_text("# This is a markdown file.")
+            (Path(tmp_dir) / "file3.py").write_text("print('Hello, world!')")
+
+            with tempfile.NamedTemporaryFile(suffix=".tempdb") as tmp_db:
+                runner = CliRunner()
+
+                result = runner.invoke(
+                    app,
+                    [
+                        "--database",
+                        tmp_db.name,
+                        "add",
+                        tmp_dir,
+                        "--only",
+                        ".md, .txt,py",
+                        "--exclude",
+                        ".py ",  # wins over --only
+                    ],
+                )
+                assert result.exit_code == 0
+
+                # Check that only .txt and .md files were added
+                assert "Processing 2 files" in result.stdout
+                assert "file1.txt" in result.stdout
+                assert "file2.md" in result.stdout
+                assert "file3.py" not in result.stdout