Skip to content

Commit 7571b4b

Browse files
committed
fix(workflow): rename codesigning steps for clarity and include notarization
1 parent cbb2605 commit 7571b4b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,15 +126,15 @@ jobs:
126126
security import certificate.p12 -k build.keychain -P "${{ secrets.CERTIFICATE_PASSWORD }}" -T /usr/bin/codesign
127127
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "${{ secrets.KEYCHAIN_PASSWORD }}" build.keychain
128128
129-
- name: codesign dylib
129+
- name: codesign and notarize dylib
130130
if: matrix.os == 'macos-15' && matrix.name != 'apple-xcframework'
131131
run: |
132132
codesign --sign "${{ secrets.APPLE_TEAM_ID }}" --timestamp --options runtime dist/cloudsync.dylib
133133
cd dist && ditto -c -k --keepParent cloudsync.dylib cloudsync.zip
134134
xcrun notarytool submit cloudsync.zip --apple-id "${{ secrets.APPLE_ID }}" --password "${{ secrets.APPLE_PASSWORD }}" --team-id "${{ secrets.APPLE_TEAM_ID }}" --wait
135135
rm cloudsync.zip
136136
137-
- name: codesign xcframework
137+
- name: codesign and notarize xcframework
138138
if: matrix.name == 'apple-xcframework'
139139
run: |
140140
find dist/CloudSync.xcframework -name "*.framework" -exec echo "Signing: {}" \; -exec codesign --sign "${{ secrets.APPLE_TEAM_ID }}" --timestamp --options runtime {} \; # Sign each individual framework FIRST

0 commit comments

Comments
 (0)