Skip to content

Commit 9f89df1

Browse files
committed
fix(build): correct platform name from 'isim' to 'ios-sim' in workflow and Makefile
1 parent 747edbf commit 9f89df1

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ permissions:
1111
jobs:
1212
build:
1313
runs-on: ${{ matrix.os }}
14-
name: ${{ matrix.name }}${{ matrix.arch && format('-{0}', matrix.arch) || '' }} build${{ matrix.arch != 'arm64-v8a' && matrix.name != 'isim' && matrix.name != 'ios' && matrix.name != 'wasm' && ' + test' || ''}}
14+
name: ${{ matrix.name }}${{ matrix.arch && format('-{0}', matrix.arch) || '' }} build${{ matrix.arch != 'arm64-v8a' && matrix.name != 'ios-sim' && matrix.name != 'ios' && matrix.name != 'wasm' && ' + test' || ''}}
1515
timeout-minutes: 20
1616
strategy:
1717
fail-fast: false
@@ -41,8 +41,8 @@ jobs:
4141
name: ios
4242
make: PLATFORM=ios
4343
- os: macos-latest
44-
name: isim
45-
make: PLATFORM=isim
44+
name: ios-sim
45+
make: PLATFORM=ios-sim
4646
- os: ubuntu-latest
4747
name: wasm
4848
make: PLATFORM=wasm

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ else ifeq ($(PLATFORM),ios)
111111
CFLAGS += -arch arm64 $(SDK)
112112
CURL_CONFIG = --host=arm64-apple-darwin --with-secure-transport CFLAGS="-arch arm64 -isysroot $$(xcrun --sdk iphoneos --show-sdk-path) -miphoneos-version-min=11.0"
113113
STRIP = strip -x -S $@
114-
else ifeq ($(PLATFORM),isim)
114+
else ifeq ($(PLATFORM),ios-sim)
115115
TARGET := $(DIST_DIR)/cloudsync.dylib
116116
SDK := -isysroot $(shell xcrun --sdk iphonesimulator --show-sdk-path) -miphonesimulator-version-min=11.0
117117
LDFLAGS += -arch x86_64 -arch arm64 -framework Security -framework CoreFoundation -dynamiclib $(SDK)
@@ -342,7 +342,7 @@ define PLIST
342342
</plist>
343343
endef
344344

345-
LIB_NAMES = ios.dylib isim.dylib macos.dylib
345+
LIB_NAMES = ios.dylib ios-sim.dylib macos.dylib
346346
FMWK_NAMES = ios-arm64 ios-arm64_x86_64-simulator macos-arm64_x86_64
347347
$(DIST_DIR)/%.xcframework: $(LIB_NAMES)
348348
@$(foreach i,1 2 3,\
@@ -380,7 +380,7 @@ help:
380380
@echo " windows (default on Windows)"
381381
@echo " android (needs ARCH to be set to x86_64 or arm64-v8a and ANDROID_NDK to be set)"
382382
@echo " ios (only on macOS - can be compiled with native network support)"
383-
@echo " isim (only on macOS - can be compiled with native network support)"
383+
@echo " ios-sim (only on macOS - can be compiled with native network support)"
384384
@echo " wasm (needs wabt[brew install wabt/sudo apt install wabt])"
385385
@echo ""
386386
@echo "Targets:"

0 commit comments

Comments
 (0)