api: Fix a 'http: superfluous response.WriteHeader' message

justinclift · justinclift · commit 6d6579b5500c · 2023-03-24T02:35:30.000+11:00
diff --git a/api/handlers.go b/api/handlers.go
@@ -1400,10 +1400,8 @@ func uploadHandler(w http.ResponseWriter, r *http.Request) {
 		jsonErr(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
+	w.WriteHeader(http.StatusCreated) // Signal the successful database creation
 	fmt.Fprintf(w, string(jsonData))
-
-	// Signal the successful database creation
-	http.Error(w, "", http.StatusCreated)
 }
 
 // viewsHandler returns the list of views in a SQLite database

Original file line number	Diff line number	Diff line change
`@@ -1400,10 +1400,8 @@ func uploadHandler(w http.ResponseWriter, r *http.Request) {`
`1400`	`1400`	`jsonErr(w, err.Error(), http.StatusInternalServerError)`
`1401`	`1401`	`return`
`1402`	`1402`	`}`
	`1403`	`+ w.WriteHeader(http.StatusCreated) // Signal the successful database creation`
`1403`	`1404`	`fmt.Fprintf(w, string(jsonData))`
`1404`		`-`
`1405`		`- // Signal the successful database creation`
`1406`		`- http.Error(w, "", http.StatusCreated)`
`1407`	`1405`	`}`
`1408`	`1406`
`1409`	`1407`	`// viewsHandler returns the list of views in a SQLite database`