Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit dd42099

Browse files
MKleusbergMKleusberg
committed
webui: Replace for by htmlFor and class by className in JSX code
1 parent 81a2b41 commit dd42099

File tree

4 files changed

+25
-25
lines changed

4 files changed

+25
-25
lines changed

‎webui/jsx/branches.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ function BranchesTableRow({name, commit, description, setStatus}) {
8989
return (<>
9090
<tr>
9191
<td style={{borderStyle: "none"}}>
92-
{authInfo.loggedInUser === meta.owner ? <button class="btn btn-primary" onClick={() => {return updateBranch()}} data-cy="savebtn">Save Changes</button> : null}
92+
{authInfo.loggedInUser === meta.owner ? <button className="btn btn-primary" onClick={() => {return updateBranch()}} data-cy="savebtn">Save Changes</button> : null}
9393
</td>
9494
<td style={{borderStyle: "none"}}>
9595
<div>
96-
{authInfo.loggedInUser === meta.owner && name !== defaultBranch ? <button class="btn btn-primary" onClick={() => {return setDefaultBranch()}} data-cy="setdefaultbtn">Set Default</button> : null }
96+
{authInfo.loggedInUser === meta.owner && name !== defaultBranch ? <button className="btn btn-primary" onClick={() => {return setDefaultBranch()}} data-cy="setdefaultbtn">Set Default</button> : null }
9797
{name === defaultBranch ? <i>Default branch</i> : null}
9898
</div>
9999
</td>
@@ -102,20 +102,20 @@ function BranchesTableRow({name, commit, description, setStatus}) {
102102
<input name={name + "_name"} id={name + "_name"} size="20" maxlength="20" value={branchName} data-cy="nameinput" onChange={(e) => setName(e.target.value)} required />
103103
:
104104
<div style={{paddingTop: "8px"}}>
105-
<a class="blackLink" href={"/" + meta.owner + "/" + meta.database + "?branch=" + name}>{name}</a>
105+
<a className="blackLink" href={"/" + meta.owner + "/" + meta.database + "?branch=" + name}>{name}</a>
106106
</div>
107107
}
108108
</td>
109109
<td style={{borderStyle: "none"}}>
110110
<div style={{paddingTop: "8px"}}>
111-
<a class="blackLink" href={"/" + meta.owner + "/" + meta.database + "?branch=" + name + "&commit=" + commit} data-cy="commitlnk">{commit}</a>
111+
<a className="blackLink" href={"/" + meta.owner + "/" + meta.database + "?branch=" + name + "&commit=" + commit} data-cy="commitlnk">{commit}</a>
112112
</div>
113113
</td>
114114
</tr>
115115
<tr>
116116
<td style={{borderStyle: "none"}}>
117-
{name !== defaultBranch ? <button class="btn btn-default" onClick={() => {return viewChanges()}} data-cy="comparebtn">{"Compare with " + defaultBranch}</button> : null}
118-
{authInfo.loggedInUser === meta.owner ? <button class="btn btn-danger" onClick={() => {return deleteBranch()}} data-cy="delbtn">Delete</button> : null}
117+
{name !== defaultBranch ? <button className="btn btn-default" onClick={() => {return viewChanges()}} data-cy="comparebtn">{"Compare with " + defaultBranch}</button> : null}
118+
{authInfo.loggedInUser === meta.owner ? <button className="btn btn-danger" onClick={() => {return deleteBranch()}} data-cy="delbtn">Delete</button> : null}
119119
</td>
120120
<td style={{borderStyle: "none", padding: 0}} colSpan={3}>
121121
<MarkdownEditor editorId={name + "_desc"} rows={10} placeholder="A description for this branch" defaultIndex={1} initialValue={description} viewOnly={meta.owner !== authInfo.loggedInUser} />
@@ -155,18 +155,18 @@ export default function BranchesTable() {
155155
return (
156156
<div>
157157
{statusMessage !== "" ? (
158-
<div class="row">
159-
<div class="col-md-12">
158+
<div className="row">
159+
<div className="col-md-12">
160160
<div style={{textAlign: "center", paddingBottom: "8px"}}>
161161
<h4 style={{color: statusMessageColour}}>&nbsp;{statusMessage}</h4>
162162
</div>
163163
</div>
164164
</div>
165165
) : null}
166-
<div class="row">
167-
<div class="col-md-12">
166+
<div className="row">
167+
<div className="col-md-12">
168168
<div style={{border: "1px solid #DDD", borderRadius: "7px", marginBottom: "10px", padding: "0"}}>
169-
<table id="contents" class="table table-striped table-responsive" style={{margin: "0"}}>
169+
<table id="contents" className="table table-striped table-responsive" style={{margin: "0"}}>
170170
<thead>
171171
<tr>
172172
<th colSpan={2}>Actions</th><th>Name</th><th>Head Commit ID</th>

‎webui/jsx/database-settings.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -312,19 +312,19 @@ export default function DatabaseSettings() {
312312
<input type="hidden" name="username" value={meta.owner} />
313313
<input type="hidden" name="dbname" value={meta.database} />
314314
<div className="form-group">
315-
<label for="newname" className="col-sm-2 control-label">Name</label>
315+
<label htmlFor="newname" className="col-sm-2 control-label">Name</label>
316316
<div className="col-sm-10">
317317
<input id="newname" name="newname" value={name} onChange={(e) => setName(e.target.value)} data-cy="nameinput" className="form-control" required />
318318
</div>
319319
</div>
320320
<div className="form-group">
321-
<label for="onelinedesc" className="col-sm-2 control-label">One line description</label>
321+
<label htmlFor="onelinedesc" className="col-sm-2 control-label">One line description</label>
322322
<div className="col-sm-10">
323323
<input id="onelinedesc" name="onelinedesc" value={oneLineDescription} onChange={(e) => setOneLineDescription(e.target.value)} data-cy="onelinedescinput" className="form-control" />
324324
</div>
325325
</div>
326326
<div className="form-group">
327-
<label for="public" className="col-sm-2 control-label">Public?</label>
327+
<label htmlFor="public" className="col-sm-2 control-label">Public?</label>
328328
<div className="col-sm-10">
329329
<div className="btn-group" data-toggle="buttons">
330330
<label className={"btn btn-default " + (isPublic ? "active" : null)} onClick={() => setPublic(true)} data-cy="public">
@@ -339,31 +339,31 @@ export default function DatabaseSettings() {
339339
</div>
340340
</div>
341341
<div className="form-group">
342-
<label for="selectdefaulttable" className="col-sm-2 control-label">Default table or view</label>
342+
<label htmlFor="selectdefaulttable" className="col-sm-2 control-label">Default table or view</label>
343343
<div className="col-sm-10">
344344
<Select name="selectdefaulttable" required={true} labelField="name" valueField="name" onChange={(values) => setDefaultTable(values[0].name)} options={tables} values={[{name: defaultTable}]} backspaceDelete={false} />
345345
<input type="hidden" name="defaulttable" value={defaultTable} />
346346
</div>
347347
</div>
348348
{meta.isLive === false ?
349349
<div className="form-group">
350-
<label for="selectbranch" className="col-sm-2 control-label">Default branch</label>
350+
<label htmlFor="selectbranch" className="col-sm-2 control-label">Default branch</label>
351351
<div className="col-sm-10">
352352
<Select name="selectbranch" required={true} labelField="name" valueField="name" onChange={(values) => switchDefaultBranch(values[0].name)} options={branches} values={[{name: defaultBranch}]} backspaceDelete={false} />
353353
<input type="hidden" name="branch" value={defaultBranch} />
354354
</div>
355355
</div>
356356
: null}
357357
<div className="form-group">
358-
<label for="sourceurl" className="col-sm-2 control-label">Source URL</label>
358+
<label htmlFor="sourceurl" className="col-sm-2 control-label">Source URL</label>
359359
<div className="col-sm-10">
360360
<input id="sourceurl" name="sourceurl" value={sourceUrl} onChange={(e) => setSourceUrl(e.target.value)} data-cy="sourceurl" className="form-control" />
361361
</div>
362362
</div>
363363
{meta.isLive === false ? <LicenceEdit /> : null}
364364
<ShareEdit />
365365
<div className="form-group">
366-
<label for="fulldesc" className="col-sm-2 control-label">Full length description<span className="help-block">Markdown (<a href="https://commonmark.org" target="_blank">CommonMark</a> format) is supported</span></label>
366+
<label htmlFor="fulldesc" className="col-sm-2 control-label">Full length description<span className="help-block">Markdown (<a href="https://commonmark.org" target="_blank">CommonMark</a> format) is supported</span></label>
367367
<div className="col-sm-10">
368368
<MarkdownEditor editorId="fulldesc" rows={18} defaultIndex={1} initialValue={fullDescription} />
369369
</div>

‎webui/jsx/discussion-create-mr.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -181,31 +181,31 @@ export default function DiscussionCreateMr() {
181181
) : null}
182182
<form>
183183
<div className="form-group">
184-
<label for="title">Title</label>
184+
<label htmlFor="title">Title</label>
185185
<input type="text" className="form-control" id="title" placeholder="Please fill in a title for the new merge request" maxlength={80} value={title} onChange={e => setTitle(e.target.value)} required />
186186
</div>
187187
<div className="form-group">
188-
<label for="sourcedb">Source database</label>
188+
<label htmlFor="sourcedb">Source database</label>
189189
<Select name="sourcedb" required={true} labelField="name" valueField="name" onChange={(values) => changeDb("source", values[0])} options={dbListData} values={[{name: sourceDbOwner + "/" + sourceDbName}]} />
190190
<p className="help-block">Where the new data is coming from</p>
191191
</div>
192192
<div className="form-group">
193-
<label for="sourcebranch">Source branch</label>
193+
<label htmlFor="sourcebranch">Source branch</label>
194194
<Select name="sourcebranch" required={true} labelField="name" valueField="name" onChange={(values) => setSourceBranch(values[0].name)} options={sourceBranchListData} values={[{name: sourceBranch}]} />
195195
<p className="help-block">The branch in the source database to use</p>
196196
</div>
197197
<div className="form-group">
198-
<label for="destdb">Destination database</label>
198+
<label htmlFor="destdb">Destination database</label>
199199
<Select name="destdb" required={true} labelField="name" valueField="name" onChange={(values) => changeDb("dest", values[0])} options={dbListData} values={[{name: destDbOwner + "/" + destDbName}]} />
200200
<p className="help-block">Where you'd like the data merged into</p>
201201
</div>
202202
<div className="form-group">
203-
<label for="destbranch">Destination branch</label>
203+
<label htmlFor="destbranch">Destination branch</label>
204204
<Select name="destbranch" required={true} labelField="name" valueField="name" onChange={(values) => setDestBranch(values[0].name)} options={destBranchListData} values={[{name: destBranch}]} />
205205
<p className="help-block">The target branch in the destination database</p>
206206
</div>
207207
<div className="form-group">
208-
<label for="desc">Description</label>
208+
<label htmlFor="desc">Description</label>
209209
<MarkdownEditor editorId="desc" rows={10} placeholder="Please add a summary for this merge request, describing what the new or changed data is for" />
210210
<p className="help-block">The purpose of this merge request</p>
211211
</div>

‎webui/jsx/markdown-editor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export default function MarkdownEditor({editorId, rows, placeholder, defaultInde
5757
{initialValue}
5858
</textarea>
5959
);
60-
let view = <div class="rendered minHeight" data-cy={editorId + "-preview"} dangerouslySetInnerHTML={{__html: previewHtml}} />;
60+
let view = <div className="rendered minHeight" data-cy={editorId + "-preview"} dangerouslySetInnerHTML={{__html: previewHtml}} />;
6161

6262
if (viewOnly) {
6363
return <>{view}{editor}</>;

0 commit comments

Comments
 (0)