Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit e9fc158

Browse files
committed
Fix some ineffectual assignments
1 parent 0add107 commit e9fc158

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

common/util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,7 @@ func DeleteBranchHistory(dbOwner string, dbFolder string, dbName string, branchN
723723
}
724724

725725
// Rewind the branch history
726-
b, ok := branchList[branchName]
726+
b, _ := branchList[branchName]
727727
b.Commit = commitID
728728
b.CommitCount = commitCount
729729
branchList[branchName] = b

webui/main.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1230,14 +1230,13 @@ func createUserHandler(w http.ResponseWriter, r *http.Request) {
12301230
errorPage(w, r, http.StatusBadRequest, err.Error())
12311231
return
12321232
}
1233-
validRegSession := false
12341233
va := sess.Values["registrationinprogress"]
12351234
if va == nil {
12361235
// This isn't a valid username selection session, so abort
12371236
errorPage(w, r, http.StatusBadRequest, "Invalid user creation session")
12381237
return
12391238
}
1240-
validRegSession = va.(bool)
1239+
validRegSession := va.(bool)
12411240
if validRegSession != true {
12421241
// This isn't a valid username selection session, so abort
12431242
errorPage(w, r, http.StatusBadRequest, "Invalid user creation session")

webui/pages.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2999,14 +2999,13 @@ func selectUserNamePage(w http.ResponseWriter, r *http.Request) {
29992999
errorPage(w, r, http.StatusBadRequest, "Invalid user creation session")
30003000
return
30013001
}
3002-
validRegSession := false
30033002
rip := sess.Values["registrationinprogress"]
30043003
if rip == nil {
30053004
// This isn't a valid username selection session, so abort
30063005
errorPage(w, r, http.StatusBadRequest, "Invalid user creation session")
30073006
return
30083007
}
3009-
validRegSession = rip.(bool)
3008+
validRegSession := rip.(bool)
30103009
if validRegSession != true {
30113010
// For some reason this isn't a valid username selection session, so abort
30123011
errorPage(w, r, http.StatusBadRequest, "Invalid user creation session")

0 commit comments

Comments
 (0)