Skip to content

Commit b29323c

Browse files
committed
fix(certificates): remove parameters for custom certificates
1 parent c65a65e commit b29323c

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

connection.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ type SQCloudConfig struct {
4848
NonLinearizable bool // Request for immediate responses from the server node without waiting for linerizability guarantees
4949
TlsInsecureSkipVerify bool // Accept invalid TLS certificates (no_verify_certificate)
5050
Pem string
51-
RootCertificate string
52-
ClientCertificate string
53-
ClientCertificateKey string
5451
ApiKey string
5552
NoBlob bool // flag to tell the server to not send BLOB columns
5653
MaxData int // value to tell the server to not send columns with more than max_data bytes
@@ -125,9 +122,6 @@ func ParseConnectionString(ConnectionString string) (config *SQCloudConfig, err
125122
config.NonLinearizable = false
126123
config.TlsInsecureSkipVerify = false
127124
config.Pem = ""
128-
config.RootCertificate = ""
129-
config.ClientCertificate = ""
130-
config.ClientCertificateKey = ""
131125
config.NoBlob = false
132126
config.MaxData = 0
133127
config.MaxRows = 0
@@ -191,12 +185,6 @@ func ParseConnectionString(ConnectionString string) (config *SQCloudConfig, err
191185
}
192186
case "tls":
193187
config.Secure, config.TlsInsecureSkipVerify, config.Pem = ParseTlsString(lastLiteral)
194-
case "root_certificate":
195-
config.RootCertificate = lastLiteral
196-
case "client_certificate":
197-
config.ClientCertificate = lastLiteral
198-
case "client_certificate_key":
199-
config.ClientCertificateKey = lastLiteral
200188
case "apikey":
201189
config.ApiKey = lastLiteral
202190
case "noblob":

test/unit/connection_test.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -155,24 +155,6 @@ func TestParseConnectionStringWithParameters(t *testing.T) {
155155
value: "true",
156156
expectedValue: true,
157157
},
158-
{
159-
param: "root_certificate",
160-
configParam: "RootCertificate",
161-
value: "cert1234",
162-
expectedValue: "cert1234",
163-
},
164-
{
165-
param: "client_certificate",
166-
configParam: "ClientCertificate",
167-
value: "cert1234",
168-
expectedValue: "cert1234",
169-
},
170-
{
171-
param: "client_certificate_key",
172-
configParam: "ClientCertificateKey",
173-
value: "certkey123",
174-
expectedValue: "certkey123",
175-
},
176158
{
177159
param: "noblob",
178160
configParam: "NoBlob",

0 commit comments

Comments
 (0)