Skip to content

Commit 39c9719

Browse files
committed
Remove direct Limit test from Oracle and SqlServer
1 parent 817c514 commit 39c9719

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

QueryBuilder.Tests/Oracle/OracleLimitTests.cs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,15 +65,13 @@ public void LimitAndOffset()
6565
var query = new Query(TableName).Limit(5).Offset(20);
6666

6767
// Act
68-
var ctx = compiler.Compile(query);
68+
var result = compiler.Compile(query);
6969

7070
// Assert:
71-
Assert.Equal("SELECT * FROM \"Table\" ORDER BY (SELECT 0 FROM DUAL) OFFSET ? ROWS FETCH NEXT ? ROWS ONLY", ctx.RawSql);
72-
Assert.Equal(2, ctx.Bindings.Count);
73-
Assert.Equal(20L, ctx.Bindings[0]);
74-
Assert.Equal(5, ctx.Bindings[1]);
75-
76-
compiler.CompileLimit(ctx);
71+
Assert.Equal("SELECT * FROM \"Table\" ORDER BY (SELECT 0 FROM DUAL) OFFSET ? ROWS FETCH NEXT ? ROWS ONLY", result.RawSql);
72+
Assert.Equal(2, result.Bindings.Count);
73+
Assert.Equal(20L, result.Bindings[0]);
74+
Assert.Equal(5, result.Bindings[1]);
7775
}
7876
}
7977
}

QueryBuilder.Tests/SqlServer/SqlServerLimitTests.cs

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,33 +15,35 @@ public SqlServerLimitTests()
1515
public void NoLimitNorOffset()
1616
{
1717
var query = new Query("Table");
18-
var ctx = new SqlResult("?", "\\") {Query = query};
1918

20-
Assert.Null(compiler.CompileLimit(ctx));
19+
var result = compiler.Compile(query);
20+
21+
Assert.Equal("SELECT * FROM [Table]", result.ToString());
2122
}
2223

2324
[Fact]
2425
public void LimitOnly()
2526
{
2627
var query = new Query("Table").Limit(10);
27-
var ctx = new SqlResult("?", "\\") {Query = query};
2828

29-
Assert.EndsWith("OFFSET ? ROWS FETCH NEXT ? ROWS ONLY", compiler.CompileLimit(ctx));
30-
Assert.Equal(2, ctx.Bindings.Count);
31-
Assert.Equal(0L, ctx.Bindings[0]);
32-
Assert.Equal(10, ctx.Bindings[1]);
29+
var result = compiler.Compile(query);
30+
31+
Assert.Equal("SELECT * FROM [Table] ORDER BY (SELECT 0) OFFSET ? ROWS FETCH NEXT ? ROWS ONLY", result.RawSql);
32+
Assert.Equal(2, result.Bindings.Count);
33+
Assert.Equal(0L, result.Bindings[0]);
34+
Assert.Equal(10, result.Bindings[1]);
3335
}
3436

3537
[Fact]
3638
public void OffsetOnly()
3739
{
3840
var query = new Query("Table").Offset(20);
39-
var ctx = new SqlResult("?", "\\") {Query = query};
4041

41-
Assert.EndsWith("OFFSET ? ROWS", compiler.CompileLimit(ctx));
42+
var result = compiler.Compile(query);
4243

43-
Assert.Single(ctx.Bindings);
44-
Assert.Equal(20L, ctx.Bindings[0]);
44+
Assert.Equal("SELECT * FROM [Table] ORDER BY (SELECT 0) OFFSET ? ROWS", result.RawSql);
45+
Assert.Single(result.Bindings);
46+
Assert.Equal(20L, result.Bindings[0]);
4547
}
4648

4749
[Fact]

0 commit comments

Comments
 (0)