remove unnecessary 'ToList()'-calls that serve no purpose

SIEDA-EliasHeydrich · SIEDA-EliasHeydrich · commit 90a8f922b8ee · 2025-08-15T14:39:10.000+02:00
diff --git a/SqlKata.Execution/QueryFactory.cs b/SqlKata.Execution/QueryFactory.cs
@@ -671,8 +671,7 @@ private static IEnumerable<T> handleIncludes<T>(Query query, IEnumerable<T> resu
 
             var dynamicResult = result
                 .Cast<IDictionary<string, object>>()
-                .Select(x => new Dictionary<string, object>(x, StringComparer.OrdinalIgnoreCase))
-                .ToList();
+                .Select(x => new Dictionary<string, object>(x, StringComparer.OrdinalIgnoreCase));
 
             foreach (var include in query.Includes)
             {
@@ -697,9 +696,7 @@ private static IEnumerable<T> handleIncludes<T>(Query query, IEnumerable<T> resu
                         include.ForeignKey = table.Singularize(false) + "Id";
                     }
 
-                    var localIds = dynamicResult.Where(x => x[include.LocalKey] != null)
-                    .Select(x => x[include.LocalKey].ToString())
-                    .ToList();
+                    var localIds = dynamicResult.Where( x => x[include.LocalKey] != null ).Select( x => x[include.LocalKey].ToString() );
 
                     if (!localIds.Any())
                     {

Original file line number	Diff line number	Diff line change
`@@ -671,8 +671,7 @@ private static IEnumerable<T> handleIncludes<T>(Query query, IEnumerable<T> resu`
`671`	`671`
`672`	`672`	`var dynamicResult = result`
`673`	`673`	`.Cast<IDictionary<string, object>>()`
`674`		`- .Select(x => new Dictionary<string, object>(x, StringComparer.OrdinalIgnoreCase))`
`675`		`- .ToList();`
	`674`	`+ .Select(x => new Dictionary<string, object>(x, StringComparer.OrdinalIgnoreCase));`
`676`	`675`
`677`	`676`	`foreach (var include in query.Includes)`
`678`	`677`	`{`
`@@ -697,9 +696,7 @@ private static IEnumerable<T> handleIncludes<T>(Query query, IEnumerable<T> resu`
`697`	`696`	`include.ForeignKey = table.Singularize(false) + "Id";`
`698`	`697`	`}`
`699`	`698`
`700`		`- var localIds = dynamicResult.Where(x => x[include.LocalKey] != null)`
`701`		`- .Select(x => x[include.LocalKey].ToString())`
`702`		`- .ToList();`
	`699`	`+ var localIds = dynamicResult.Where( x => x[include.LocalKey] != null ).Select( x => x[include.LocalKey].ToString() );`
`703`	`700`
`704`	`701`	`if (!localIds.Any())`
`705`	`702`	`{`