Skip to content

Commit 3b5f293

Browse files
committed
Refactor DeleteQueryBuilder and related tests to use double quotes for table names in SQL queries, ensuring consistency and compatibility with case-sensitive databases. Clean up import statements for improved readability.
1 parent dae3f03 commit 3b5f293

File tree

4 files changed

+11
-16
lines changed

4 files changed

+11
-16
lines changed

__tests__/delete-builder.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { DeleteQueryBuilder, SqlExecutor } from "../src";
2-
import { SimpleWhere, CompositeWhere } from "../src/types/query";
2+
import { SimpleWhere, CompositeWhere } from "../src";
33

44
// Mock SqlExecutor
55
const mockExecutor: SqlExecutor = {
@@ -26,15 +26,15 @@ describe("DeleteQueryBuilder", () => {
2626
it("should build correct SQL for basic delete", () => {
2727
const result = builder.build();
2828

29-
expect(result.sql).toContain("DELETE FROM users");
29+
expect(result.sql).toContain(`DELETE FROM "users"`);
3030
expect(result.sql).toContain("RETURNING *");
3131
expect(result.values).toEqual([]);
3232
});
3333

3434
it("should build correct SQL for delete with specific returning columns", () => {
3535
const result = builder.returning(["id", "name"]).build();
3636

37-
expect(result.sql).toContain("DELETE FROM users");
37+
expect(result.sql).toContain(`DELETE FROM "users"`);
3838
expect(result.sql).toContain("RETURNING id, name");
3939
expect(result.values).toEqual([]);
4040
});
@@ -50,7 +50,7 @@ describe("DeleteQueryBuilder", () => {
5050

5151
const result = builder.where(where).build();
5252

53-
expect(result.sql).toContain("DELETE FROM users");
53+
expect(result.sql).toContain(`DELETE FROM "users"`);
5454
expect(result.sql).toContain(`WHERE "users"."age" > $1`);
5555
expect(result.sql).toContain("RETURNING *");
5656
expect(result.values).toEqual([18]);

src/query-builder/delete.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { SqlExecutor } from "../types/common";
2-
import { WhereCondition } from "../types/query";
3-
import { buildWhereClause } from "../utils/clauses";
1+
import { SqlExecutor } from "../types";
2+
import { WhereCondition } from "../types";
3+
import { buildWhereClause } from "../utils";
44
import { BaseQueryBuilder } from "./base";
55

66
export class DeleteQueryBuilder<T> extends BaseQueryBuilder<T> {
@@ -36,8 +36,6 @@ export class DeleteQueryBuilder<T> extends BaseQueryBuilder<T> {
3636
${whereClause ? `WHERE ${whereClause}` : ""}
3737
RETURNING ${returning};
3838
`;
39-
console.log(sql);
40-
console.log(values);
4139
return { sql, values };
4240
}
4341
}

src/query-builder/select.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import { SqlExecutor } from "../types/common";
1+
import { SqlExecutor } from "../types";
22
import {
33
PaginatedResult,
44
PaginationMeta,
55
PaginationOptions,
6-
} from "../types/pagination";
7-
import { Join, OrderBy, QueryPayload, WhereCondition } from "../types/query";
6+
} from "../types";
7+
import { Join, OrderBy, QueryPayload, WhereCondition } from "../types";
88
import {
99
buildJoinClause,
1010
buildOrderByClause,
@@ -93,8 +93,6 @@ export class SelectQueryBuilder<T> extends BaseQueryBuilder<T> {
9393
${limit ? `LIMIT ${limit}` : ""} ${offset ? `OFFSET ${offset}` : ""};
9494
`;
9595

96-
console.log(sql);
97-
9896
return { sql, values };
9997
}
10098

@@ -108,7 +106,7 @@ export class SelectQueryBuilder<T> extends BaseQueryBuilder<T> {
108106
this.offset(offset);
109107

110108
// Execute the main query for data
111-
const result = await this.execute();
109+
const result = await this.commit();
112110
const nodes = result.rows as T[];
113111

114112
// Execute count query for pagination metadata

src/utils/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
export * from "./clauses";
22
export * from "./formatting";
3-
export * from "./infer-model";

0 commit comments

Comments
 (0)