Refactor test files for improved clarity and consistency

- Updated SQL queries in CSV data tests to use uppercase column names.
- Simplified database table management in core tests by separating drop and create statements.
- Enhanced transaction tests to utilize an enum for database type handling.

Author: lovasoa

tests/core/mod.rs

@@ -1,5 +1,8 @@
 use actix_web::{http::StatusCode, test};
-use sqlpage::{webserver, AppState};
+use sqlpage::{
+    webserver::{self, make_placeholder},
+    AppState,
+};
 use sqlx::Executor as _;
 
 use crate::common::{make_app_data_from_config, req_path, req_path_with_app_data, test_config};
@@ -47,21 +50,21 @@ async fn test_routing_with_db_fs() {
     config.site_prefix = "/prefix/".to_string();
     let state = AppState::init(&config).await.unwrap();
 
+    let drop_sql = "DROP TABLE IF EXISTS sqlpage_files";
+    state.db.connection.execute(drop_sql).await.unwrap();
     let create_table_sql =
         sqlpage::filesystem::DbFsQueries::get_create_table_sql(state.db.info.database_type);
-    state
-        .db
-        .connection
-        .execute(format!("DROP TABLE IF EXISTS sqlpage_files; {create_table_sql}").as_ref())
+    state.db.connection.execute(create_table_sql).await.unwrap();
+    let insert_sql = format!(
+        "INSERT INTO sqlpage_files(path, contents) VALUES ('on_db.sql', {})",
+        make_placeholder(state.db.info.kind, 1)
+    );
+    sqlx::query(&insert_sql)
+        .bind("select ''text'' as component, ''Hi from db !'' AS contents;".as_bytes())
+        .execute(&state.db.connection)
         .await
         .unwrap();
 
-    let insert_sql = match state.db.connection.any_kind() {
-        sqlx::any::AnyKind::Mssql => "INSERT INTO sqlpage_files(path, contents) VALUES ('on_db.sql', CONVERT(VARBINARY(MAX), 'select ''text'' as component, ''Hi from db !'' AS contents;'))",
-        _ => "INSERT INTO sqlpage_files(path, contents) VALUES ('on_db.sql', 'select ''text'' as component, ''Hi from db !'' AS contents;')"
-    };
-    state.db.connection.execute(insert_sql).await.unwrap();
-
     let state = AppState::init(&config).await.unwrap();
     let app_data = actix_web::web::Data::new(state);
 

tests/data_formats/csv_data.sql

@@ -1,4 +1,11 @@
-select 'csv' as component, ';' as separator;
-select 0 as id, 'Hello World !' as msg
+select
+    'csv' as component,
+    ';' as separator;
+
+select
+    0 as ID,
+    'Hello World !' as MSG
 union all
-select 1 as id, 'Tu gères '';'' et ''"'' ?' as msg;
+select
+    1 as ID,
+    'Tu gères '';'' et ''"'' ?' as MSG;

tests/data_formats/mod.rs

@@ -43,7 +43,7 @@ async fn test_csv_body() -> actix_web::Result<()> {
     let body_str = String::from_utf8(body.to_vec()).unwrap();
     assert_eq!(
         body_str,
-        "id;msg\n0;Hello World !\n1;\"Tu gères ';' et '\"\"' ?\"\n"
+        "ID;MSG\n0;Hello World !\n1;\"Tu gères ';' et '\"\"' ?\"\n"
     );
     Ok(())
 }

tests/transactions/mod.rs

@@ -1,14 +1,17 @@
 use actix_web::{http::StatusCode, test};
-use sqlpage::webserver::http::main_handler;
+use sqlpage::webserver::{database::SupportedDatabase, http::main_handler};
 
 use crate::common::{get_request_to_with_data, make_app_data};
 
 #[actix_web::test]
 async fn test_transaction_error() -> actix_web::Result<()> {
     let data = make_app_data().await;
-    let path = match data.db.to_string().to_lowercase().as_str() {
-        "mysql" => "/tests/transactions/failed_transaction_mysql.sql",
-        "mssql" => "/tests/transactions/failed_transaction_mssql.sql",
+    let path = match data.db.info.database_type {
+        SupportedDatabase::MySql => "/tests/transactions/failed_transaction_mysql.sql",
+        SupportedDatabase::Mssql => "/tests/transactions/failed_transaction_mssql.sql",
+        SupportedDatabase::Snowflake => {
+            return Ok(()); //snowflake doesn't support transactions
+        }
         _ => "/tests/transactions/failed_transaction.sql",
     };
     let req = get_request_to_with_data(path, data.clone())