Skip to content

Commit 18cdb63

Browse files
committed
fix infinite error stream issue
It was possible for an SQL error to trigger an infinite loop where SQLPage would stream error messages to the browsers forever
1 parent dea7485 commit 18cdb63

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/webserver/database/mod.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,11 @@ pub async fn stream_query_results<'a>(
121121
};
122122
let mut stream = query.fetch_many(connection);
123123
while let Some(elem) = stream.next().await {
124-
yield parse_single_sql_result(elem)
124+
let is_err = elem.is_err();
125+
yield parse_single_sql_result(elem);
126+
if is_err {
127+
break;
128+
}
125129
}
126130
},
127131
ParsedSQLStatement::StaticSimpleSelect(value) => {

0 commit comments

Comments
 (0)