Use live db for tests

Author: lovasoa

src/app_config.rs

@@ -53,10 +53,6 @@ impl AppConfig {
             config.configuration_directory.clone_from(config_dir);
         }
 
-        if let Some(config_dir) = &cli.config_dir {
-            config.configuration_directory.clone_from(config_dir);
-        }
-
         config.configuration_directory = std::fs::canonicalize(&config.configuration_directory)
             .unwrap_or_else(|_| config.configuration_directory.clone());
 
@@ -507,17 +503,24 @@ impl DevOrProd {
     }
 }
 
+#[must_use]
+pub fn test_database_url() -> String {
+    std::env::var("DATABASE_URL").unwrap_or_else(|_| "sqlite::memory:".to_string())
+}
+
 #[cfg(test)]
 pub mod tests {
+    pub use super::test_database_url;
     use super::AppConfig;
 
     #[must_use]
     pub fn test_config() -> AppConfig {
         serde_json::from_str::<AppConfig>(
-            r#"{
-            "database_url": "sqlite::memory:",
-            "listen_on": "localhost:8080"
-        }"#,
+            &serde_json::json!({
+                "database_url": test_database_url(),
+                "listen_on": "localhost:8080"
+            })
+            .to_string(),
         )
         .unwrap()
     }

src/webserver/database/sql_to_json.rs

@@ -112,6 +112,8 @@ pub fn row_to_string(row: &AnyRow) -> Option<String> {
 
 #[cfg(test)]
 mod tests {
+    use crate::app_config::tests::test_database_url;
+
     use super::*;
     use sqlx::Connection;
 
@@ -124,8 +126,7 @@ mod tests {
 
     fn db_specific_test(db_type: &str) -> Option<String> {
         setup_logging();
-        let db_url =
-            std::env::var("DATABASE_URL").unwrap_or_else(|_| "sqlite://:memory:".to_string());
+        let db_url = test_database_url();
         if db_url.starts_with(db_type) {
             Some(db_url)
         } else {
@@ -137,8 +138,7 @@ mod tests {
     #[actix_web::test]
     async fn test_row_to_json() -> anyhow::Result<()> {
         use sqlx::Connection;
-        let db_url =
-            std::env::var("DATABASE_URL").unwrap_or_else(|_| "sqlite://:memory:".to_string());
+        let db_url = test_database_url();
         let mut c = sqlx::AnyConnection::connect(&db_url).await?;
         let row = sqlx::query(
             "SELECT \

tests/index.rs

@@ -12,7 +12,7 @@ use actix_web::{
     HttpResponse,
 };
 use sqlpage::{
-    app_config::AppConfig,
+    app_config::{test_database_url, AppConfig},
     webserver::{self, http::main_handler},
     AppState,
 };
@@ -580,7 +580,7 @@ async fn req_path_with_app_data(
 }
 
 pub fn test_config() -> AppConfig {
-    let db_url = std::env::var("DATABASE_URL").unwrap_or_else(|_| "sqlite::memory:".to_string());
+    let db_url = test_database_url();
     serde_json::from_str::<AppConfig>(&format!(
         r#"{{
         "database_url": "{}",