Refactor CI workflow to use testable scripts

- Move test logic from workflow to scripts/ci-test-{deb,rpm}.sh
- Tests now verify manpage installation
- Scripts can be run locally for faster iteration
- Reduces workflow from 304 to 267 lines

Author: lovasoa

.github/workflows/packages.yml

@@ -184,35 +184,15 @@ jobs:
         version: ["bookworm", "bullseye"]
     container: debian:${{ matrix.version }}
     steps:
+      - uses: actions/checkout@v4
+      
       - name: Download DEB package
         uses: actions/download-artifact@v4
         with:
           name: debian-package
 
-      - name: Install package
-        run: |
-          apt-get update
-          apt-get install -y ./sqlpage*.deb
-      
-      - name: Verify installation
-        run: |
-          sqlpage --version
-          which sqlpage
-          dpkg -l | grep sqlpage
-          test -f /usr/bin/sqlpage
-          test -d /etc/sqlpage
-          test -f /etc/sqlpage/sqlpage.json
-          test -d /etc/sqlpage/templates
-          test -f /lib/systemd/system/sqlpage.service
-      
-      - name: Test service file
-        run: |
-          systemctl cat sqlpage.service || cat /lib/systemd/system/sqlpage.service
-      
-      - name: Verify user creation
-        run: |
-          id sqlpage
-          getent passwd sqlpage
+      - name: Run DEB tests
+        run: bash scripts/ci-test-deb.sh ./sqlpage*.deb
 
   test-deb-ubuntu:
     name: Test DEB on Ubuntu ${{ matrix.version }}
@@ -223,28 +203,15 @@ jobs:
         version: ["24.04", "22.04", "20.04"]
     container: ubuntu:${{ matrix.version }}
     steps:
+      - uses: actions/checkout@v4
+      
       - name: Download DEB package
         uses: actions/download-artifact@v4
         with:
           name: debian-package
 
-      - name: Install package
-        run: |
-          apt-get update
-          apt-get install -y ./sqlpage*.deb
-      
-      - name: Verify installation
-        run: |
-          sqlpage --version
-          which sqlpage
-          dpkg -l | grep sqlpage
-          test -f /usr/bin/sqlpage
-          test -d /etc/sqlpage
-          test -f /etc/sqlpage/sqlpage.json
-      
-      - name: Test service file
-        run: |
-          systemctl cat sqlpage.service || cat /lib/systemd/system/sqlpage.service
+      - name: Run DEB tests
+        run: bash scripts/ci-test-deb.sh ./sqlpage*.deb
 
   test-rpm:
     name: Test RPM on ${{ matrix.container }}
@@ -255,18 +222,15 @@ jobs:
         container: [fedora:latest, rockylinux:8]
     container: ${{ matrix.container }}
     steps:
+      - uses: actions/checkout@v4
+      
       - name: Download RPM package
         uses: actions/download-artifact@v4
         with:
           name: rpm-package
 
-      - name: Install package manager dependencies
-        run: yum install -y curl sudo ./x86_64/*.rpm
-
-      - name: Test SQLPage functionality
-        run: |
-          echo "SELECT 'json' as component; SELECT 1 as it_works;" > /var/www/sqlpage/index.sql
-          cd /var/www/sqlpage && sqlpage & sleep 2 && curl -sf http://localhost:8080/ | grep -q it_works && kill %1
+      - name: Run RPM tests
+        run: bash scripts/ci-test-rpm.sh ./x86_64/*.rpm
 
   publish-packages:
     name: Publish Packages to GitHub Release

scripts/ci-test-deb.sh

@@ -0,0 +1,38 @@
+#!/bin/bash
+set -euo pipefail
+
+PACKAGE_FILE=${1:-sqlpage*.deb}
+
+echo "=== Installing package ==="
+apt-get update -qq
+apt-get install -y "$PACKAGE_FILE"
+
+echo "=== Verifying installation ==="
+sqlpage --version
+which sqlpage
+dpkg -l | grep sqlpage
+
+echo "=== Checking files ==="
+test -f /usr/bin/sqlpage
+test -d /etc/sqlpage
+test -f /etc/sqlpage/sqlpage.json
+test -d /etc/sqlpage/templates
+test -f /lib/systemd/system/sqlpage.service
+test -f /usr/share/man/man1/sqlpage.1.gz
+
+echo "=== Verifying systemd service ==="
+systemctl cat sqlpage.service || cat /lib/systemd/system/sqlpage.service
+
+echo "=== Verifying user ==="
+id sqlpage
+getent passwd sqlpage
+
+echo "=== Testing functionality ==="
+echo "SELECT 'json' as component; SELECT 1 as it_works;" > /var/www/sqlpage/index.sql
+cd /var/www/sqlpage
+timeout 5 sqlpage &
+sleep 2
+curl -sf http://localhost:8080/ | grep -q it_works
+pkill sqlpage || true
+
+echo "✓ All DEB tests passed!"

scripts/ci-test-rpm.sh

@@ -0,0 +1,41 @@
+#!/bin/bash
+set -euo pipefail
+
+PACKAGE_FILE=${1:-x86_64/*.rpm}
+
+echo "=== Installing package ==="
+if command -v dnf &> /dev/null; then
+    dnf install -y curl $PACKAGE_FILE
+else
+    yum install -y curl $PACKAGE_FILE
+fi
+
+echo "=== Verifying installation ==="
+sqlpage --version
+which sqlpage
+rpm -qi sqlpage
+
+echo "=== Checking files ==="
+test -f /usr/bin/sqlpage
+test -d /etc/sqlpage
+test -f /etc/sqlpage/sqlpage.json
+test -d /etc/sqlpage/templates
+test -f /usr/lib/systemd/system/sqlpage.service
+test -f /usr/share/man/man1/sqlpage.1.gz
+
+echo "=== Verifying systemd service ==="
+systemctl cat sqlpage.service || cat /usr/lib/systemd/system/sqlpage.service
+
+echo "=== Verifying user ==="
+id sqlpage
+getent passwd sqlpage
+
+echo "=== Testing functionality ==="
+echo "SELECT 'json' as component; SELECT 1 as it_works;" > /var/www/sqlpage/index.sql
+cd /var/www/sqlpage
+timeout 5 sqlpage &
+sleep 2
+curl -sf http://localhost:8080/ | grep -q it_works
+pkill sqlpage || true
+
+echo "✓ All RPM tests passed!"