Skip to content

Commit 709ffb6

Browse files
committed
Fix submenu scroll issue by enabling autoclose
This is a workaround for #1011 until tabler releases the proper fix.
1 parent 2018478 commit 709ffb6

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## O.37.1
44
- fixed decoding of UUID values
55
- Fixed handling of NULL values in `sqlpage.link`. They were encoded as the string `'null'` instead of being omitted from the link's parameters.
6+
- Enable submenu autoclosing (on click) in the shell. This is not ideal, but this prevents a bug introduced in v0.36.0 where the page would scroll back to the top when clicking anywhere on the page after navigating from a submenu. The next version will fix this properly. See https://github.com/sqlpage/SQLPage/issues/1011
67

78
## v0.37.0
89
- We now cryptographically sign the Windows app during releases, which proves the file hasn’t been tampered with. Once the production certificate is active, Windows will show a "verified publisher" and should stop showing screens saying "This app might harm your device", "Windows protected your PC" or "Are you sure you want to run this application ?".

sqlpage/templates/shell.handlebars

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,12 @@
9696
{{#if (or (or this.title this.icon) this.image)}}
9797
<li class="nav-item{{#if this.submenu}} dropdown{{/if}}{{#if this.active}} active{{/if}}">
9898
<a class="nav-link {{#if this.submenu}}dropdown-toggle{{/if}}" href="{{#if this.link}}{{this.link}}{{else}}#{{/if}}"
99-
{{~#if this.submenu}} data-bs-toggle="dropdown" data-bs-auto-close="outside" {{/if~}}
99+
{{~#if this.submenu}}
100+
data-bs-toggle="dropdown"
101+
{{!-- commented out until this is fixed: https://github.com/tabler/tabler/issues/2485
102+
data-bs-auto-close="outside"
103+
--}}
104+
{{/if~}}
100105
{{#if this.target}}target="{{this.target}}"{{/if}}
101106
role="button"
102107
>

0 commit comments

Comments
 (0)