When NULL is passed as an icon name, display no icon instead of raising an error.

Author: lovasoa

CHANGELOG.md

@@ -4,6 +4,9 @@
  - Add support for scatter and bubble plots in the chart component. See [the chart documentation](https://sql.ophir.dev/documentation.sql?component=chart#component).
  - further improve debuggability with more precise error messages. In particular, it usd to be hard to debug errors in long migration scripts, because the line number and position was not displayed. This is now fixed.
  - Add a new `top_image` attribute to the [card](https://sql.ophir.dev/documentation.sql?component=card#component) component to display an image at the top of the card. This makes it possible to create beautiful image galleries with SQLPage.
+ - Updated dependencies, for bug fixes and performance improvements.
+ - New icons (see https://tabler-icons.io/changelog)
+ - When `NULL` is passed as an icon name, display no icon instead of raising an error.
 
 ## 0.12.0 (2023-10-04)
 

src/templates.rs

@@ -169,12 +169,13 @@ fn icon_img_helper<'reg, 'rc>(
 ) -> handlebars::HelperResult {
     let null = handlebars::JsonValue::Null;
     let params = [0, 1].map(|i| helper.params().get(i).map_or(&null, PathAndJson::value));
-    let err_fmt = || {
-        RenderErrorReason::Other(format!(
-            "{{icon_img str int}}: invalid parameters {params:?}"
-        ))
+    let name = match params[0] {
+        JsonValue::String(s) => s,
+        other => {
+            log::debug!("icon_img: {other:?} is not an icon name, not rendering anything");
+            return Ok(());
+        }
     };
-    let name = params[0].as_str().ok_or_else(err_fmt)?;
     let size = params[1].as_u64().unwrap_or(24);
     write!(
         writer,