fix #621

lovasoa · lovasoa · commit dd94371c44bb · 2024-10-04T09:23:42.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG.md
 
+## 0.30.0 (unreleased)
+
+ - **Fix**: the search feature in the shell component was not working when no menu item was defined.
+
 ## 0.29.0 (2024-09-25)
  - New columns component: `columns`. Useful to display a comparison between items, or large key figures to an user.
    - ![screenshot](https://github.com/user-attachments/assets/89e4ac34-864c-4427-a926-c38e9bed3f86)
diff --git a/sqlpage/templates/shell.handlebars b/sqlpage/templates/shell.handlebars
@@ -158,7 +158,7 @@
 
 <body class="layout-{{#if sidebar}}fluid{{else}}{{default layout 'boxed'}}{{/if}}" {{#if theme}}data-bs-theme="{{theme}}" {{/if}}>
     <div class="page">
-        {{#if (or (or title (or icon image)) menu_item)}}
+        {{#if (or (or title (or icon image)) (or menu_item search_target))}}
         <header id="sqlpage_header">
         {{#if sidebar}}
         <aside class="navbar navbar-vertical navbar-expand-lg" {{#if sidebar_theme}}data-bs-theme="{{sidebar_theme}}" {{/if}}>
@@ -196,7 +196,7 @@
                 <h1 class="mb-0 fs-2 text-truncate flex-grow-1" style="flex-basis:0">
                     <a class="text-decoration-none" href="{{#if link}}{{link}}{{else}}/{{/if}}">{{default navbar_title title}}</a>
                 </h1>
-                {{#if menu_item}}
+                {{#if (or menu_item search_target)}}
                 <button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbar-menu" aria-controls="navbar-menu" aria-expanded="false" aria-label="Toggle navigation">
                     <span class="navbar-toggler-icon"></span>
                 </button>
diff --git a/tests/sql_test_files/it_works_shell_search.sql b/tests/sql_test_files/it_works_shell_search.sql
@@ -0,0 +1,3 @@
+select 'shell' as component,
+    '/' as search_target,
+    'It works !' as search_value;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+select 'shell' as component,`
	`2`	`+ '/' as search_target,`
	`3`	`+ 'It works !' as search_value;`