Add Translatable Options for Search Elements

[amrutadotorg]

Hi, I'm working on a multilingual website. There are three places where I haven't been able to dynamically modify the text:

Search Placeholder: <input class="form-control me-2" type="search" placeholder="Search" aria-label="Search" name="search" value="">

Search Button: <button class="btn btn-outline-success" type="submit">Search</button>

Search Field (Table Component): <input type="search" class="form-control form-control-rounded fs-6 search" placeholder="Search…" value="">

It would be great to add options to the shell and table components to make these elements translatable.

thank you

[lovasoa]

You are right ! Could you please open a pull request with the change ?

The templates in https://github.com/sqlpage/SQLPage/tree/main/sqlpage/templates and the documentation in https://github.com/sqlpage/SQLPage/tree/main/examples/official-site/sqlpage/migrations need to be updated together.

If this helps, you can find a contribution guide here: https://github.com/sqlpage/SQLPage/blob/main/CONTRIBUTING.md

[amrutadotorg]

great, what would you say of having in the table component
placeholder="{{default search_placeholder_value 'Search…'}}"

and for the shell component
<input class="form-control me-2" type="search" placeholder="{{default search_placeholder_value 'Search'}}" aria-label="Search" name="search" value="{{search_value}}">
and
<button class="btn btn-outline-success" type="submit">{{default search_button 'Search'}}</button>

table.handlebars.txt

shell.handlebars.txt

[lovasoa]

maybe just search_placeholder instead of search_placeholder_value ?

[amrutadotorg]

done #893

[lovasoa]

Great, thank you ! We'll close this issue when we merge your pull request