fix: clippy warnings in tests and macros

- Fix deprecated chrono DateTime::from_utc usage
- Add workspace lint config to allow postgres_14 cfg
- Fix dead code warnings in sqlx-macros query data
- Fix needless_borrows_for_generic_args in sqlx-macros
- Fix useless_conversion by removing redundant .into()
- Fix useless_vec by using array instead of vec! in test

Author: cursoragent

Cargo.toml

@@ -18,6 +18,9 @@ members = [
     "examples/sqlite/todos",
 ]
 
+[workspace.lints.rust]
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(postgres_14)'] }
+
 [package]
 name = "sqlx-oldapi"
 version = "0.6.48"

sqlx-macros/src/query/data.rs

@@ -80,6 +80,7 @@ pub mod offline {
     }
 
     #[derive(serde::Deserialize)]
+    #[allow(dead_code)]
     pub struct DynQueryData {
         #[serde(skip)]
         pub db_name: String,
@@ -153,6 +154,7 @@ pub mod offline {
     where
         Describe<DB>: serde::Serialize + serde::de::DeserializeOwned,
     {
+        #[allow(dead_code)]
         pub fn from_dyn_data(dyn_data: DynQueryData) -> crate::Result<Self> {
             assert!(!dyn_data.db_name.is_empty());
             assert!(!dyn_data.hash.is_empty());

sqlx-macros/src/query/mod.rs

@@ -49,7 +49,7 @@ impl Metadata {
             let cargo = env("CARGO").expect("`CARGO` must be set");
 
             let output = Command::new(&cargo)
-                .args(&["metadata", "--format-version=1", "--no-deps"])
+                .args(["metadata", "--format-version=1", "--no-deps"])
                 .current_dir(&self.manifest_dir)
                 .env_remove("__CARGO_FIX_PLZ")
                 .output()
@@ -78,8 +78,7 @@ static METADATA: Lazy<Metadata> = Lazy::new(|| {
 
     #[cfg(feature = "offline")]
     let package_name: String = env("CARGO_PKG_NAME")
-        .expect("`CARGO_PKG_NAME` must be set")
-        .into();
+        .expect("`CARGO_PKG_NAME` must be set");
 
     #[cfg(feature = "offline")]
     let target_dir = env("CARGO_TARGET_DIR").map_or_else(|_| "target".into(), |dir| dir.into());

tests/mssql/mssql.rs

@@ -530,7 +530,7 @@ CREATE TABLE #qb_test (
         name: String,
     }
 
-    let items_to_insert = vec![
+    let items_to_insert = [
         TestItem {
             id: 1,
             name: "Alice".to_string(),

tests/mysql/types.rs

@@ -88,15 +88,15 @@ mod chrono {
 
     test_type!(chrono_timestamp<DateTime::<Utc>>(MySql,
         "TIMESTAMP '2019-01-02 05:10:20.115100'"
-            == DateTime::<Utc>::from_utc(
+            == DateTime::from_naive_utc_and_offset(
                 NaiveDateTime::parse_from_str("2019-01-02 05:10:20.115100", "%Y-%m-%d %H:%M:%S%.f").unwrap(),
                 Utc,
             )
     ));
 
     test_type!(chrono_fixed_offset<DateTime::<FixedOffset>>(MySql,
         "TIMESTAMP '2019-01-02 05:10:20.115100'"
-            == DateTime::<Utc>::from_utc(
+            == DateTime::from_naive_utc_and_offset(
                 NaiveDateTime::parse_from_str("2019-01-02 05:10:20.115100", "%Y-%m-%d %H:%M:%S%.f").unwrap(),
                 Utc,
             )

tests/postgres/types.rs

@@ -286,7 +286,7 @@ mod chrono {
 
     test_type!(chrono_date_time_tz_utc<DateTime::<Utc>>(Postgres,
         "TIMESTAMPTZ '2019-01-02 05:10:20.115100'"
-            == DateTime::<Utc>::from_utc(
+            == DateTime::from_naive_utc_and_offset(
                 NaiveDate::from_ymd_opt(2019, 1, 2).unwrap().and_hms_micro_opt(5, 10, 20, 115100).unwrap(),
                 Utc,
             )
@@ -300,7 +300,7 @@ mod chrono {
     test_type!(chrono_date_time_tz_vec<Vec<DateTime::<Utc>>>(Postgres,
         "array['2019-01-02 05:10:20.115100']::timestamptz[]"
             == vec![
-                DateTime::<Utc>::from_utc(
+                DateTime::from_naive_utc_and_offset(
                     NaiveDate::from_ymd_opt(2019, 1, 2).unwrap().and_hms_micro_opt(5, 10, 20, 115100).unwrap(),
                     Utc,
                 )