fix: resolve auto-deref and other clippy warnings

- Remove explicit derefs that would be done by auto-deref
- Fix needless borrows in various modules
- Replace is_digit(10) with is_ascii_digit()
- Fix doc list indentation in postgres/copy.rs

Author: cursoragent

sqlx-core/src/net/tls/mod.rs

@@ -162,9 +162,7 @@ where
                 Ok(())
             }
 
-            MaybeTlsStream::Upgrading => {
-                Err(Error::Io(io::ErrorKind::ConnectionAborted.into()))
-            }
+            MaybeTlsStream::Upgrading => Err(Error::Io(io::ErrorKind::ConnectionAborted.into())),
         }
     }
 }

sqlx-core/src/postgres/connection/executor.rs

@@ -48,7 +48,7 @@ async fn prepare(
 
     // next we send the PARSE command to the server
     conn.stream.write(Parse {
-        param_types: &*param_types,
+        param_types: &param_types,
         query: sql,
         statement: id,
     });
@@ -228,7 +228,7 @@ impl PgConnection {
                 formats: &[PgValueFormat::Binary],
                 #[allow(clippy::cast_possible_truncation, clippy::cast_possible_wrap)]
                 num_params: arguments.types.len() as i16,
-                params: &*arguments.buffer,
+                params: &arguments.buffer,
                 result_formats: &[PgValueFormat::Binary],
             });
 

sqlx-core/src/postgres/connection/sasl.rs

@@ -107,7 +107,7 @@ pub(crate) async fn authenticate(
     let client_key = mac.finalize().into_bytes();
 
     // StoredKey := H(ClientKey)
-    let stored_key = Sha256::digest(&client_key);
+    let stored_key = Sha256::digest(client_key);
 
     // client-final-message-without-proof
     let client_final_message_wo_proof = format!(
@@ -126,7 +126,7 @@ pub(crate) async fn authenticate(
 
     // ClientSignature := HMAC(StoredKey, AuthMessage)
     let mut mac = Hmac::<Sha256>::new_from_slice(&stored_key).map_err(Error::protocol)?;
-    mac.update(&auth_message.as_bytes());
+    mac.update(auth_message.as_bytes());
 
     let client_signature = mac.finalize().into_bytes();
 
@@ -145,7 +145,7 @@ pub(crate) async fn authenticate(
 
     // ServerSignature := HMAC(ServerKey, AuthMessage)
     let mut mac = Hmac::<Sha256>::new_from_slice(&server_key).map_err(Error::protocol)?;
-    mac.update(&auth_message.as_bytes());
+    mac.update(auth_message.as_bytes());
 
     // client-final-message = client-final-message-without-proof "," proof
     let client_final_message = format!(
@@ -203,7 +203,7 @@ fn gen_nonce() -> String {
 fn hi<'a>(s: &'a str, salt: &'a [u8], iter_count: u32) -> Result<[u8; 32], Error> {
     let mut mac = Hmac::<Sha256>::new_from_slice(s.as_bytes()).map_err(Error::protocol)?;
 
-    mac.update(&salt);
+    mac.update(salt);
     mac.update(&1u32.to_be_bytes());
 
     let mut u = mac.finalize().into_bytes();

sqlx-core/src/postgres/connection/stream.rs

@@ -203,7 +203,7 @@ fn parse_server_version(s: &str) -> Option<u32> {
                     break;
                 }
             }
-            _ if ch.is_digit(10) => {
+            _ if ch.is_ascii_digit() => {
                 if chs.peek().is_none() {
                     if let Ok(num) = u32::from_str(&s[from..]) {
                         parts.push(num);

sqlx-core/src/postgres/copy.rs

@@ -42,7 +42,7 @@ impl PgConnection {
     ///
     /// 1. by closing the connection, or:
     /// 2. by using another connection to kill the server process that is sending the data as shown
-    /// [in this StackOverflow answer](https://stackoverflow.com/a/35319598).
+    ///    [in this StackOverflow answer](https://stackoverflow.com/a/35319598).
     ///
     /// If you don't read the stream to completion, the next time the connection is used it will
     /// need to read and discard all the remaining queued data, which could take some time.
@@ -90,7 +90,7 @@ impl Pool<Postgres> {
     ///
     /// 1. by closing the connection, or:
     /// 2. by using another connection to kill the server process that is sending the data as shown
-    /// [in this StackOverflow answer](https://stackoverflow.com/a/35319598).
+    ///    [in this StackOverflow answer](https://stackoverflow.com/a/35319598).
     ///
     /// If you don't read the stream to completion, the next time the connection is used it will
     /// need to read and discard all the remaining queued data, which could take some time.
@@ -208,7 +208,7 @@ impl<C: DerefMut<Target = PgConnection>> PgCopyIn<C> {
             // ensures the buffer isn't left in an inconsistent state
             let mut guard = BufGuard(&mut buf_stream.wbuf);
 
-            let buf: &mut Vec<u8> = &mut guard.0;
+            let buf: &mut Vec<u8> = guard.0;
             buf.push(b'd'); // CopyData format code
             buf.resize(5, 0); // reserve space for the length
 

sqlx-core/src/postgres/message/authentication.rs

@@ -162,8 +162,8 @@ impl Decode<'_> for AuthenticationSaslContinue {
         Ok(Self {
             iterations,
             salt,
-            nonce: from_utf8(&*nonce).map_err(Error::protocol)?.to_owned(),
-            message: from_utf8(&*buf).map_err(Error::protocol)?.to_owned(),
+            nonce: from_utf8(&nonce).map_err(Error::protocol)?.to_owned(),
+            message: from_utf8(&buf).map_err(Error::protocol)?.to_owned(),
         })
     }
 }

sqlx-core/src/postgres/options/parse.rs

@@ -28,15 +28,15 @@ impl FromStr for PgConnectOptions {
         let username = url.username();
         if !username.is_empty() {
             options = options.username(
-                &*percent_decode_str(username)
+                &percent_decode_str(username)
                     .decode_utf8()
                     .map_err(Error::config)?,
             );
         }
 
         if let Some(password) = url.password() {
             options = options.password(
-                &*percent_decode_str(password)
+                &percent_decode_str(password)
                     .decode_utf8()
                     .map_err(Error::config)?,
             );