Checkpoint before follow-up message

cursoragent · lovasoa · cursoragent · commit 2e348c89751d · 2025-09-19T18:17:39.000Z
Co-authored-by: contact &lt;contact@ophir.dev&gt;
diff --git a/Cargo.toml b/Cargo.toml
@@ -58,7 +58,7 @@ offline = ["sqlx-macros/offline", "sqlx-core/offline"]
 
 # intended mainly for CI and docs
 all = ["tls", "all-databases", "all-types"]
-all-databases = ["mysql", "sqlite", "postgres", "mssql", "snowflake", "any"]
+all-databases = ["mysql", "sqlite", "postgres", "mssql", "any"]
 all-types = [
     "bigdecimal",
     "decimal",
diff --git a/sqlx-core/Cargo.toml b/sqlx-core/Cargo.toml
@@ -20,7 +20,7 @@ default = ["migrate"]
 migrate = ["sha2", "crc"]
 
 # databases
-all-databases = ["postgres", "mysql", "sqlite", "mssql", "snowflake", "any"]
+all-databases = ["postgres", "mysql", "sqlite", "mssql", "any"]
 postgres = [
     "md-5",
     "sha2",
diff --git a/sqlx-core/src/any/arguments.rs b/sqlx-core/src/any/arguments.rs
@@ -46,12 +46,6 @@ pub(crate) enum AnyArgumentBufferKind<'q> {
         crate::mssql::MssqlArguments,
         std::marker::PhantomData<&'q ()>,
     ),
-
-    #[cfg(feature = "snowflake")]
-    Snowflake(
-        crate::snowflake::SnowflakeArguments,
-        std::marker::PhantomData<&'q ()>,
-    ),
 }
 
 // control flow inferred type bounds would be fun
diff --git a/sqlx-core/src/any/connection/establish.rs b/sqlx-core/src/any/connection/establish.rs
@@ -34,13 +34,6 @@ impl AnyConnection {
                     .await
                     .map(AnyConnectionKind::Mssql)
             }
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectOptionsKind::Snowflake(options) => {
-                crate::snowflake::SnowflakeConnection::establish(options)
-                    .await
-                    .map(AnyConnectionKind::Snowflake)
-            }
         }
         .map(AnyConnection)
     }
diff --git a/sqlx-core/src/any/connection/mod.rs b/sqlx-core/src/any/connection/mod.rs
@@ -15,10 +15,6 @@ use crate::mssql;
 
 #[cfg(feature = "mysql")]
 use crate::mysql;
-
-#[cfg(feature = "snowflake")]
-use crate::snowflake;
-
 use crate::transaction::Transaction;
 
 mod establish;
@@ -52,9 +48,6 @@ pub enum AnyConnectionKind {
 
     #[cfg(feature = "sqlite")]
     Sqlite(sqlite::SqliteConnection),
-
-    #[cfg(feature = "snowflake")]
-    Snowflake(snowflake::SnowflakeConnection),
 }
 
 impl AnyConnectionKind {
@@ -71,9 +64,6 @@ impl AnyConnectionKind {
 
             #[cfg(feature = "mssql")]
             AnyConnectionKind::Mssql(_) => AnyKind::Mssql,
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectionKind::Snowflake(_) => AnyKind::Snowflake,
         }
     }
 }
@@ -104,9 +94,6 @@ macro_rules! delegate_to {
 
             #[cfg(feature = "mssql")]
             AnyConnectionKind::Mssql(conn) => conn.$method($($arg),*),
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectionKind::Snowflake(conn) => conn.$method($($arg),*),
         }
     };
 }
@@ -125,9 +112,6 @@ macro_rules! delegate_to_mut {
 
             #[cfg(feature = "mssql")]
             AnyConnectionKind::Mssql(conn) => conn.$method($($arg),*),
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectionKind::Snowflake(conn) => conn.$method($($arg),*),
         }
     };
 }
@@ -150,9 +134,6 @@ impl Connection for AnyConnection {
 
             #[cfg(feature = "mssql")]
             AnyConnectionKind::Mssql(conn) => conn.close(),
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectionKind::Snowflake(conn) => conn.close(),
         }
     }
 
@@ -169,9 +150,6 @@ impl Connection for AnyConnection {
 
             #[cfg(feature = "mssql")]
             AnyConnectionKind::Mssql(conn) => conn.close_hard(),
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectionKind::Snowflake(conn) => conn.close_hard(),
         }
     }
 
@@ -200,9 +178,6 @@ impl Connection for AnyConnection {
             // no cache
             #[cfg(feature = "mssql")]
             AnyConnectionKind::Mssql(_) => 0,
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectionKind::Snowflake(conn) => conn.cached_statements_size(),
         }
     }
 
@@ -220,9 +195,6 @@ impl Connection for AnyConnection {
             // no cache
             #[cfg(feature = "mssql")]
             AnyConnectionKind::Mssql(_) => Box::pin(futures_util::future::ok(())),
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectionKind::Snowflake(conn) => conn.clear_cached_statements(),
         }
     }
 
@@ -264,10 +236,3 @@ impl From<sqlite::SqliteConnection> for AnyConnection {
         AnyConnection(AnyConnectionKind::Sqlite(conn))
     }
 }
-
-#[cfg(feature = "snowflake")]
-impl From<snowflake::SnowflakeConnection> for AnyConnection {
-    fn from(conn: snowflake::SnowflakeConnection) -> Self {
-        AnyConnection(AnyConnectionKind::Snowflake(conn))
-    }
-}
diff --git a/sqlx-core/src/any/kind.rs b/sqlx-core/src/any/kind.rs
@@ -14,9 +14,6 @@ pub enum AnyKind {
 
     #[cfg(feature = "mssql")]
     Mssql,
-
-    #[cfg(feature = "snowflake")]
-    Snowflake,
 }
 
 impl FromStr for AnyKind {
@@ -64,16 +61,6 @@ impl FromStr for AnyKind {
                 Err(Error::Configuration("database URL has the scheme of a MSSQL database but the `mssql` feature is not enabled".into()))
             }
 
-            #[cfg(feature = "snowflake")]
-            _ if url.starts_with("snowflake:") => {
-                Ok(AnyKind::Snowflake)
-            }
-
-            #[cfg(not(feature = "snowflake"))]
-            _ if url.starts_with("snowflake:") => {
-                Err(Error::Configuration("database URL has the scheme of a Snowflake database but the `snowflake` feature is not enabled".into()))
-            }
-
             _ => Err(Error::Configuration(format!("unrecognized database url: {:?}", url).into()))
         }
     }
diff --git a/sqlx-core/src/any/mod.rs b/sqlx-core/src/any/mod.rs
@@ -82,9 +82,6 @@ where
 
             #[cfg(feature = "sqlite")]
             arguments::AnyArgumentBufferKind::Sqlite(args) => args.add(self),
-
-            #[cfg(feature = "snowflake")]
-            arguments::AnyArgumentBufferKind::Snowflake(args, _) => args.add(self),
         }
 
         // unused
diff --git a/sqlx-core/src/any/options.rs b/sqlx-core/src/any/options.rs
@@ -19,9 +19,6 @@ use crate::any::kind::AnyKind;
 #[cfg(feature = "mssql")]
 use crate::mssql::MssqlConnectOptions;
 
-#[cfg(feature = "snowflake")]
-use crate::snowflake::SnowflakeConnectOptions;
-
 /// Opaque options for connecting to a database. These may only be constructed by parsing from
 /// a connection url.
 ///
@@ -46,9 +43,6 @@ impl AnyConnectOptions {
 
             #[cfg(feature = "mssql")]
             AnyConnectOptionsKind::Mssql(_) => AnyKind::Mssql,
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectOptionsKind::Snowflake(_) => AnyKind::Snowflake,
         }
     }
 }
@@ -114,12 +108,6 @@ try_from_any_connect_options_to!(
 #[cfg(feature = "mssql")]
 try_from_any_connect_options_to!(MssqlConnectOptions, AnyConnectOptionsKind::Mssql, "mssql");
 
-#[cfg(feature = "snowflake")]
-try_from_any_connect_options_to!(
-    SnowflakeConnectOptions,
-    AnyConnectOptionsKind::Snowflake,
-    "snowflake"
-);
 
 #[derive(Debug, Clone)]
 pub(crate) enum AnyConnectOptionsKind {
@@ -134,9 +122,6 @@ pub(crate) enum AnyConnectOptionsKind {
 
     #[cfg(feature = "mssql")]
     Mssql(MssqlConnectOptions),
-
-    #[cfg(feature = "snowflake")]
-    Snowflake(SnowflakeConnectOptions),
 }
 
 #[cfg(feature = "postgres")]
@@ -167,13 +152,6 @@ impl From<MssqlConnectOptions> for AnyConnectOptions {
     }
 }
 
-#[cfg(feature = "snowflake")]
-impl From<SnowflakeConnectOptions> for AnyConnectOptions {
-    fn from(options: SnowflakeConnectOptions) -> Self {
-        Self(AnyConnectOptionsKind::Snowflake(options))
-    }
-}
-
 impl FromStr for AnyConnectOptions {
     type Err = Error;
 
@@ -194,11 +172,6 @@ impl FromStr for AnyConnectOptions {
 
             #[cfg(feature = "mssql")]
             AnyKind::Mssql => MssqlConnectOptions::from_str(url).map(AnyConnectOptionsKind::Mssql),
-
-            #[cfg(feature = "snowflake")]
-            AnyKind::Snowflake => {
-                SnowflakeConnectOptions::from_str(url).map(AnyConnectOptionsKind::Snowflake)
-            }
         }
         .map(AnyConnectOptions)
     }
@@ -233,11 +206,6 @@ impl ConnectOptions for AnyConnectOptions {
             AnyConnectOptionsKind::Mssql(o) => {
                 o.log_statements(level);
             }
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectOptionsKind::Snowflake(o) => {
-                o.log_statements(level);
-            }
         };
         self
     }
@@ -263,11 +231,6 @@ impl ConnectOptions for AnyConnectOptions {
             AnyConnectOptionsKind::Mssql(o) => {
                 o.log_slow_statements(level, duration);
             }
-
-            #[cfg(feature = "snowflake")]
-            AnyConnectOptionsKind::Snowflake(o) => {
-                o.log_slow_statements(level, duration);
-            }
         };
         self
     }

Original file line number	Diff line number	Diff line change
`@@ -34,13 +34,6 @@ impl AnyConnection {`
`34`	`34`	`.await`
`35`	`35`	`.map(AnyConnectionKind::Mssql)`
`36`	`36`	`}`
`37`		`-`
`38`		`- #[cfg(feature = "snowflake")]`
`39`		`- AnyConnectOptionsKind::Snowflake(options) => {`
`40`		`- crate::snowflake::SnowflakeConnection::establish(options)`
`41`		`- .await`
`42`		`- .map(AnyConnectionKind::Snowflake)`
`43`		`- }`
`44`	`37`	`}`
`45`	`38`	`.map(AnyConnection)`
`46`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,10 +15,6 @@ use crate::mssql;`
`15`	`15`
`16`	`16`	`#[cfg(feature = "mysql")]`
`17`	`17`	`use crate::mysql;`
`18`		`-`
`19`		`-#[cfg(feature = "snowflake")]`
`20`		`-use crate::snowflake;`
`21`		`-`
`22`	`18`	`use crate::transaction::Transaction;`
`23`	`19`
`24`	`20`	`mod establish;`
`@@ -52,9 +48,6 @@ pub enum AnyConnectionKind {`
`52`	`48`
`53`	`49`	`#[cfg(feature = "sqlite")]`
`54`	`50`	`Sqlite(sqlite::SqliteConnection),`
`55`		`-`
`56`		`- #[cfg(feature = "snowflake")]`
`57`		`- Snowflake(snowflake::SnowflakeConnection),`
`58`	`51`	`}`
`59`	`52`
`60`	`53`	`impl AnyConnectionKind {`
`@@ -71,9 +64,6 @@ impl AnyConnectionKind {`
`71`	`64`
`72`	`65`	`#[cfg(feature = "mssql")]`
`73`	`66`	`AnyConnectionKind::Mssql(_) => AnyKind::Mssql,`
`74`		`-`
`75`		`- #[cfg(feature = "snowflake")]`
`76`		`- AnyConnectionKind::Snowflake(_) => AnyKind::Snowflake,`
`77`	`67`	`}`
`78`	`68`	`}`
`79`	`69`	`}`
`@@ -104,9 +94,6 @@ macro_rules! delegate_to {`
`104`	`94`
`105`	`95`	`#[cfg(feature = "mssql")]`
`106`	`96`	`AnyConnectionKind::Mssql(conn) => conn.$method($($arg),*),`
`107`		`-`
`108`		`- #[cfg(feature = "snowflake")]`
`109`		`- AnyConnectionKind::Snowflake(conn) => conn.$method($($arg),*),`
`110`	`97`	`}`
`111`	`98`	`};`
`112`	`99`	`}`
`@@ -125,9 +112,6 @@ macro_rules! delegate_to_mut {`
`125`	`112`
`126`	`113`	`#[cfg(feature = "mssql")]`
`127`	`114`	`AnyConnectionKind::Mssql(conn) => conn.$method($($arg),*),`
`128`		`-`
`129`		`- #[cfg(feature = "snowflake")]`
`130`		`- AnyConnectionKind::Snowflake(conn) => conn.$method($($arg),*),`
`131`	`115`	`}`
`132`	`116`	`};`
`133`	`117`	`}`
`@@ -150,9 +134,6 @@ impl Connection for AnyConnection {`
`150`	`134`
`151`	`135`	`#[cfg(feature = "mssql")]`
`152`	`136`	`AnyConnectionKind::Mssql(conn) => conn.close(),`
`153`		`-`
`154`		`- #[cfg(feature = "snowflake")]`
`155`		`- AnyConnectionKind::Snowflake(conn) => conn.close(),`
`156`	`137`	`}`
`157`	`138`	`}`
`158`	`139`
`@@ -169,9 +150,6 @@ impl Connection for AnyConnection {`
`169`	`150`
`170`	`151`	`#[cfg(feature = "mssql")]`
`171`	`152`	`AnyConnectionKind::Mssql(conn) => conn.close_hard(),`
`172`		`-`
`173`		`- #[cfg(feature = "snowflake")]`
`174`		`- AnyConnectionKind::Snowflake(conn) => conn.close_hard(),`
`175`	`153`	`}`
`176`	`154`	`}`
`177`	`155`
`@@ -200,9 +178,6 @@ impl Connection for AnyConnection {`
`200`	`178`	`// no cache`
`201`	`179`	`#[cfg(feature = "mssql")]`
`202`	`180`	`AnyConnectionKind::Mssql(_) => 0,`
`203`		`-`
`204`		`- #[cfg(feature = "snowflake")]`
`205`		`- AnyConnectionKind::Snowflake(conn) => conn.cached_statements_size(),`
`206`	`181`	`}`
`207`	`182`	`}`
`208`	`183`
`@@ -220,9 +195,6 @@ impl Connection for AnyConnection {`
`220`	`195`	`// no cache`
`221`	`196`	`#[cfg(feature = "mssql")]`
`222`	`197`	`AnyConnectionKind::Mssql(_) => Box::pin(futures_util::future::ok(())),`
`223`		`-`
`224`		`- #[cfg(feature = "snowflake")]`
`225`		`- AnyConnectionKind::Snowflake(conn) => conn.clear_cached_statements(),`
`226`	`198`	`}`
`227`	`199`	`}`
`228`	`200`
`@@ -264,10 +236,3 @@ impl From<sqlite::SqliteConnection> for AnyConnection {`
`264`	`236`	`AnyConnection(AnyConnectionKind::Sqlite(conn))`
`265`	`237`	`}`
`266`	`238`	`}`
`267`		`-`
`268`		`-#[cfg(feature = "snowflake")]`
`269`		`-impl From<snowflake::SnowflakeConnection> for AnyConnection {`
`270`		`- fn from(conn: snowflake::SnowflakeConnection) -> Self {`
`271`		`- AnyConnection(AnyConnectionKind::Snowflake(conn))`
`272`		`- }`
`273`		`-}`
Original file line number	Diff line number	Diff line change
`@@ -14,9 +14,6 @@ pub enum AnyKind {`
`14`	`14`
`15`	`15`	`#[cfg(feature = "mssql")]`
`16`	`16`	`Mssql,`
`17`		`-`
`18`		`- #[cfg(feature = "snowflake")]`
`19`		`- Snowflake,`
`20`	`17`	`}`
`21`	`18`
`22`	`19`	`impl FromStr for AnyKind {`
`@@ -64,16 +61,6 @@ impl FromStr for AnyKind {`
`64`	`61`	Err(Error::Configuration("database URL has the scheme of a MSSQL database but the `mssql` feature is not enabled".into()))
`65`	`62`	`}`
`66`	`63`
`67`		`- #[cfg(feature = "snowflake")]`
`68`		`- _ if url.starts_with("snowflake:") => {`
`69`		`- Ok(AnyKind::Snowflake)`
`70`		`- }`
`71`		`-`
`72`		`- #[cfg(not(feature = "snowflake"))]`
`73`		`- _ if url.starts_with("snowflake:") => {`
`74`		- Err(Error::Configuration("database URL has the scheme of a Snowflake database but the `snowflake` feature is not enabled".into()))
`75`		`- }`
`76`		`-`
`77`	`64`	`_ => Err(Error::Configuration(format!("unrecognized database url: {:?}", url).into()))`
`78`	`65`	`}`
`79`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,9 +82,6 @@ where`
`82`	`82`
`83`	`83`	`#[cfg(feature = "sqlite")]`
`84`	`84`	`arguments::AnyArgumentBufferKind::Sqlite(args) => args.add(self),`
`85`		`-`
`86`		`- #[cfg(feature = "snowflake")]`
`87`		`- arguments::AnyArgumentBufferKind::Snowflake(args, _) => args.add(self),`
`88`	`85`	`}`
`89`	`86`
`90`	`87`	`// unused`