sqlite: remove clippy allows; switch columns Vec->slice; simplify wildcard matches

Author: cursoragent

examples/postgres/axum-social-with-tests/tests/common.rs

@@ -1,5 +1,4 @@
 // This is imported by different tests that use different functions.
-#![allow(dead_code)]
 
 use axum::body::{Body, BoxBody, HttpBody};
 use axum::http::header::CONTENT_TYPE;

sqlx-core/src/io/buf_stream.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use std::io;
 use std::ops::{Deref, DerefMut};
 

sqlx-core/src/io/mod.rs

@@ -1,4 +1,3 @@
-#![allow(unused_imports)]
 mod buf;
 mod buf_mut;
 mod buf_stream;

sqlx-core/src/lib.rs

@@ -2,7 +2,7 @@
 //! Not intended to be used directly.
 #![recursion_limit = "512"]
 #![warn(future_incompatible, rust_2018_idioms)]
-#![allow(clippy::needless_doctest_main, clippy::type_complexity, dead_code)]
+#![allow(clippy::needless_doctest_main, clippy::type_complexity)]
 #![deny(
     clippy::cast_possible_truncation,
     clippy::cast_possible_wrap,

sqlx-core/src/net/socket.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use std::io;
 use std::net::SocketAddr;
 use std::path::Path;

sqlx-core/src/net/tls/mod.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use std::io;
 use std::ops::{Deref, DerefMut};
 use std::path::PathBuf;

sqlx-core/src/postgres/type_info.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 use std::borrow::Cow;
 use std::fmt::{self, Display, Formatter};
 use std::ops::Deref;

sqlx-core/src/sqlite/connection/explain.rs

@@ -228,7 +228,6 @@ impl CursorDataType {
     }
 }
 
-#[allow(clippy::wildcard_in_or_patterns)]
 fn affinity_to_type(affinity: u8) -> DataType {
     match affinity {
         SQLITE_AFF_BLOB => DataType::Blob,
@@ -237,19 +236,18 @@ fn affinity_to_type(affinity: u8) -> DataType {
         SQLITE_AFF_REAL => DataType::Float,
         SQLITE_AFF_TEXT => DataType::Text,
 
-        SQLITE_AFF_NONE | _ => DataType::Null,
+        _ => DataType::Null,
     }
 }
 
-#[allow(clippy::wildcard_in_or_patterns)]
 fn opcode_to_type(op: &str) -> DataType {
     match op {
         OP_REAL => DataType::Float,
         OP_BLOB => DataType::Blob,
         OP_AND | OP_OR => DataType::Bool,
         OP_ROWID | OP_COUNT | OP_INT64 | OP_INTEGER => DataType::Int64,
         OP_STRING8 => DataType::Text,
-        OP_COLUMN | _ => DataType::Null,
+        _ => DataType::Null,
     }
 }
 

sqlx-core/src/sqlite/mod.rs

@@ -3,7 +3,6 @@
 // SQLite is a C library. All interactions require FFI which is unsafe.
 // All unsafe blocks should have comments pointing to SQLite docs and ensuring that we maintain
 // invariants.
-#![allow(unsafe_code)]
 
 pub use arguments::{SqliteArgumentValue, SqliteArguments};
 pub use column::SqliteColumn;

sqlx-core/src/sqlite/row.rs

@@ -1,5 +1,3 @@
-#![allow(clippy::rc_buffer)]
-
 use std::sync::Arc;
 
 use crate::HashMap;
@@ -14,7 +12,7 @@ use crate::sqlite::{Sqlite, SqliteColumn, SqliteValue, SqliteValueRef};
 /// Implementation of [`Row`] for SQLite.
 pub struct SqliteRow {
     pub(crate) values: Box<[SqliteValue]>,
-    pub(crate) columns: Arc<Vec<SqliteColumn>>,
+    pub(crate) columns: Arc<[SqliteColumn]>,
     pub(crate) column_names: Arc<HashMap<UStr, usize>>,
 }
 
@@ -32,7 +30,7 @@ unsafe impl Sync for SqliteRow {}
 impl SqliteRow {
     pub(crate) fn current(
         statement: &StatementHandle,
-        columns: &Arc<Vec<SqliteColumn>>,
+        columns: &Arc<[SqliteColumn]>,
         column_names: &Arc<HashMap<UStr, usize>>,
     ) -> Self {
         let size = statement.column_count();