fix: clippy warnings for mssql, any, postgres, and sqlite modules

- Remove empty line after doc comment in tls_prelogin_stream_wrapper.rs
- Fix needless_borrow in ustr.rs, logger.rs, any/statement.rs
- Fix unneeded_return in logger.rs
- Add allow for large_enum_variant in AnyConnectionKind
- Fix never_loop in postgres time_tz.rs by simplifying DateTime parsing
- Fix module_inception by renaming time module to time_impl
- Fix manual_div_ceil using div_ceil method
- Fix deref which would be done by auto-deref in sqlite/column.rs
- Fix wrong_self_convention by making as_int take &self
- Fix useless_conversion and needless_borrow in sqlite/connection/execute.rs

Author: cursoragent

sqlx-core/src/any/connection/mod.rs

@@ -35,6 +35,7 @@ pub struct AnyConnection(pub(super) AnyConnectionKind);
 #[derive(Debug)]
 // Used internally in `sqlx-macros`
 #[doc(hidden)]
+#[allow(clippy::large_enum_variant)]
 pub enum AnyConnectionKind {
     #[cfg(feature = "postgres")]
     Postgres(postgres::PgConnection),

sqlx-core/src/any/statement.rs

@@ -33,7 +33,7 @@ impl<'q> Statement<'q> for AnyStatement<'q> {
 
     fn parameters(&self) -> Option<Either<&[AnyTypeInfo], usize>> {
         match &self.parameters {
-            Some(Either::Left(types)) => Some(Either::Left(&types)),
+            Some(Either::Left(types)) => Some(Either::Left(types)),
             Some(Either::Right(count)) => Some(Either::Right(*count)),
             None => None,
         }
@@ -54,7 +54,7 @@ where
         statement
             .column_names
             .get(*self)
+            .copied()
             .ok_or_else(|| Error::ColumnNotFound((*self).into()))
-            .map(|v| *v)
     }
 }

sqlx-core/src/postgres/types/bit_vec.rs

@@ -65,7 +65,7 @@ impl Decode<'_, Postgres> for BitVec {
                 };
 
                 // The smallest amount of data we can read is one byte
-                let bytes_len = (len + 7) / 8;
+                let bytes_len = len.div_ceil(8);
 
                 if bytes.remaining() != bytes_len {
                     Err(io::Error::new(

sqlx-core/src/postgres/types/time/mod.rs

@@ -1,6 +1,6 @@
 mod date;
 mod datetime;
-mod time;
+mod time_impl;
 
 #[rustfmt::skip]
 const PG_EPOCH: ::time::Date = ::time::macros::date!(2000-1-1);

sqlx-core/src/postgres/types/time/time.rs …ore/src/postgres/types/time/time_impl.rssqlx-core/src/postgres/types/time/time.rs renamed to sqlx-core/src/postgres/types/time/time_impl.rs sqlx-core/src/postgres/types/time/time.rs renamed to sqlx-core/src/postgres/types/time/time_impl.rs

@@ -99,23 +99,8 @@ mod chrono {
                     tmp.push_str("2001-07-08 ");
                     tmp.push_str(s);
 
-                    let dt = 'out: loop {
-                        let mut err = None;
-
-                        for fmt in &["%Y-%m-%d %H:%M:%S%.f%#z", "%Y-%m-%d %H:%M:%S%.f"] {
-                            match DateTime::parse_from_str(&tmp, fmt) {
-                                Ok(dt) => {
-                                    break 'out dt;
-                                }
-
-                                Err(error) => {
-                                    err = Some(error);
-                                }
-                            }
-                        }
-
-                        return Err(err.unwrap().into());
-                    };
+                    let dt = DateTime::parse_from_str(&tmp, "%Y-%m-%d %H:%M:%S%.f%#z")
+                        .or_else(|_| DateTime::parse_from_str(&tmp, "%Y-%m-%d %H:%M:%S%.f"))?;
 
                     let time = dt.time();
                     let offset = *dt.offset();

sqlx-core/src/postgres/types/time_tz.rs

@@ -20,7 +20,7 @@ impl Column for SqliteColumn {
     }
 
     fn name(&self) -> &str {
-        &*self.name
+        &self.name
     }
 
     fn type_info(&self) -> &SqliteTypeInfo {

sqlx-core/src/sqlite/column.rs

@@ -28,7 +28,7 @@ enum SqliteLoadExtensionMode {
 }
 
 impl SqliteLoadExtensionMode {
-    fn as_int(self) -> c_int {
+    fn as_int(&self) -> c_int {
         match self {
             SqliteLoadExtensionMode::Enable => 1,
             SqliteLoadExtensionMode::DisableAll => 0,

sqlx-core/src/sqlite/connection/establish.rs

@@ -71,7 +71,7 @@ impl Iterator for ExecuteIter<'_> {
             let mut statement = match self.statement.prepare_next(self.handle) {
                 Ok(Some(statement)) => statement,
                 Ok(None) => return None,
-                Err(e) => return Some(Err(e.into())),
+                Err(e) => return Some(Err(e)),
             };
 
             self.goto_next = false;
@@ -83,7 +83,7 @@ impl Iterator for ExecuteIter<'_> {
 
             statement.handle.clear_bindings();
 
-            match bind(&mut statement.handle, &self.args, self.args_used) {
+            match bind(&mut statement.handle, self.args, self.args_used) {
                 Ok(args_used) => self.args_used += args_used,
                 Err(e) => return Some(Err(e)),
             }
@@ -100,7 +100,7 @@ impl Iterator for ExecuteIter<'_> {
                 Some(Ok(Either::Right(SqliteRow::current(
                     &statement.handle,
                     &statement.columns,
-                    &statement.column_names,
+                    statement.column_names,
                 ))))
             }
             Ok(false) => {