fix: resolve clippy warnings in query, io, and tls modules

- Fix reference to reference pattern in query.rs
- Remove redundant closure using and_then directly
- Remove needless borrows in io/buf.rs and logger.rs
- Replace iter().cloned().collect() with to_vec() for better performance
- Use std::io::Error::other() instead of Error::new(ErrorKind::Other)

Author: cursoragent

sqlx-core/src/io/buf.rs

@@ -22,7 +22,7 @@ pub trait BufExt: Buf {
 impl BufExt for Bytes {
     fn get_bytes_nul(&mut self) -> Result<Bytes, Error> {
         let nul =
-            memchr(b'\0', &self).ok_or_else(|| err_protocol!("expected NUL in byte sequence"))?;
+            memchr(b'\0', self).ok_or_else(|| err_protocol!("expected NUL in byte sequence"))?;
 
         let v = self.slice(0..nul);
 
@@ -40,7 +40,7 @@ impl BufExt for Bytes {
 
     fn get_str_nul(&mut self) -> Result<String, Error> {
         self.get_bytes_nul().and_then(|bytes| {
-            from_utf8(&*bytes)
+            from_utf8(&bytes)
                 .map(ToOwned::to_owned)
                 .map_err(|err| err_protocol!("{}", err))
         })

sqlx-core/src/logger.rs

@@ -47,7 +47,7 @@ impl<'q> QueryLogger<'q> {
             .to_level()
             .filter(|lvl| log::log_enabled!(target: "sqlx::query", *lvl))
         {
-            let mut summary = parse_query_summary(&self.sql);
+            let mut summary = parse_query_summary(self.sql);
 
             let sql = if summary != self.sql {
                 summary.push_str(" …");
@@ -126,7 +126,7 @@ impl<'q, O: Debug + Hash + Eq, R: Debug, P: Debug> QueryPlanLogger<'q, O, R, P>
             .to_level()
             .filter(|lvl| log::log_enabled!(target: "sqlx::explain", *lvl))
         {
-            let mut summary = parse_query_summary(&self.sql);
+            let mut summary = parse_query_summary(self.sql);
 
             let sql = if summary != self.sql {
                 summary.push_str(" …");

sqlx-core/src/net/tls/rustls.rs

@@ -72,14 +72,14 @@ pub async fn configure_tls_connector(
             .with_custom_certificate_verifier(Arc::new(DummyTlsVerifier))
     } else {
         let mut cert_store = RootCertStore {
-            roots: webpki_roots::TLS_SERVER_ROOTS.iter().cloned().collect(),
+            roots: webpki_roots::TLS_SERVER_ROOTS.to_vec(),
         };
 
         if let Some(ca) = tls_config.root_cert_path {
             let path_description = ca.to_string();
             let data = ca.data().await.map_err(|e| RustlsError::ParsePemCert {
                 file_description: path_description.clone(),
-                source: std::io::Error::new(std::io::ErrorKind::Other, e),
+                source: std::io::Error::other(e),
             })?;
             let mut cursor = Cursor::new(data);
 
@@ -116,13 +116,13 @@ pub async fn configure_tls_connector(
             let cert_chain = certs_from_pem(cert_path.data().await.map_err(|e| {
                 RustlsError::ParseClientCert {
                     file_description: cert_file_desc.clone(),
-                    source: std::io::Error::new(std::io::ErrorKind::Other, e),
+                    source: std::io::Error::other(e),
                 }
             })?)?;
             let key_der = private_key_from_pem(key_path.data().await.map_err(|e| {
                 RustlsError::ParseClientKey {
                     file_description: key_file_desc.clone(),
-                    source: std::io::Error::new(std::io::ErrorKind::Other, e),
+                    source: std::io::Error::other(e),
                 }
             })?)?;
             config

sqlx-core/src/query.rs

@@ -51,7 +51,7 @@ where
 
     fn statement(&self) -> Option<&<DB as HasStatement<'q>>::Statement> {
         match self.statement {
-            Either::Right(ref statement) => Some(&statement),
+            Either::Right(ref statement) => Some(statement),
             Either::Left(_) => None,
         }
     }
@@ -293,7 +293,7 @@ where
         let mut f = self.mapper;
         Map {
             inner: self.inner,
-            mapper: move |row| f(row).and_then(|o| g(o)),
+            mapper: move |row| f(row).and_then(g),
         }
     }