fix: clippy warnings in mysql testing and mssql modules

- Fix op_ref by using direct comparison in mysql/migrate.rs
- Fix needless_borrows_for_generic_args in mysql/testing/mod.rs
- Fix drop_non_drop by using let binding instead of drop
- Fix single_char_add_str by using push() with char literal
- Fix explicit_auto_deref in mssql/column.rs and establish.rs
- Fix io_other_error by using std::io::Error::other()
- Fix unnecessary_map_or by using is_some_and()
- Fix unit_arg by using Default::default()
- Add allow for let_unit_value due to platform differences

Author: cursoragent

sqlx-core/src/mssql/arguments.rs

@@ -86,7 +86,7 @@ impl MssqlArguments {
         //  @p1 int, @p2 nvarchar(10), ...
 
         if !declarations.is_empty() {
-            declarations.push_str(",");
+            declarations.push(',');
         }
 
         declarations.push_str(name);

sqlx-core/src/mssql/column.rs

@@ -33,7 +33,7 @@ impl Column for MssqlColumn {
     }
 
     fn name(&self) -> &str {
-        &*self.name
+        &self.name
     }
 
     fn type_info(&self) -> &MssqlTypeInfo {

sqlx-core/src/mssql/connection/establish.rs

@@ -43,8 +43,7 @@ impl MssqlConnection {
                 stream.setup_encryption().await?;
             }
             (Encrypt::Required, Encrypt::Off | Encrypt::NotSupported) => {
-                return Err(Error::Tls(Box::new(std::io::Error::new(
-                    std::io::ErrorKind::Other,
+                return Err(Error::Tls(Box::new(std::io::Error::other(
                     "TLS encryption required but not supported by server",
                 ))));
             }
@@ -73,7 +72,7 @@ impl MssqlConnection {
             server_name: &options.server_name,
             client_interface_name: &options.client_interface_name,
             language: &options.language,
-            database: &*options.database,
+            database: &options.database,
             client_id: [0; 6],
         };
 

sqlx-core/src/mssql/connection/prepare.rs

@@ -28,7 +28,7 @@ pub(crate) async fn prepare(
 
     for m in PARAMS_RE.captures_iter(sql) {
         if !params.is_empty() {
-            params.push_str(",");
+            params.push(',');
         }
 
         params.push_str(&m[0]);

sqlx-core/src/mssql/connection/stream.rs

@@ -142,7 +142,7 @@ impl MssqlStream {
     // TDS communicates in streams of packets that are themselves streams of messages
     pub(super) async fn recv_message(&mut self) -> Result<Message, Error> {
         loop {
-            while self.response.as_ref().map_or(false, |r| !r.1.is_empty()) {
+            while self.response.as_ref().is_some_and(|r| !r.1.is_empty()) {
                 let buf = if let Some((_, buf)) = self.response.as_mut() {
                     buf
                 } else {

sqlx-core/src/mssql/connection/tls_prelogin_stream_wrapper.rs

@@ -100,14 +100,14 @@ impl<S: AsyncRead + AsyncWrite + Unpin + Send> AsyncRead for TlsPreloginWrapper<
 
                 let read = header_buf.filled().len();
                 if read == 0 {
-                    return Poll::Ready(Ok(PollReadOut::default()));
+                    return Poll::Ready(Ok(Default::default()));
                 }
 
                 inner.header_pos += read;
             }
 
             let header: PacketHeader = Decode::decode(Bytes::copy_from_slice(&inner.header_buf))
-                .map_err(|err| io::Error::new(io::ErrorKind::Other, err))?;
+                .map_err(|err| io::Error::other(err))?;
 
             inner.read_remaining = usize::from(header.length) - HEADER_BYTES;
 
@@ -121,6 +121,7 @@ impl<S: AsyncRead + AsyncWrite + Unpin + Send> AsyncRead for TlsPreloginWrapper<
         let max_read = std::cmp::min(inner.read_remaining, buf.remaining());
         let mut limited_buf = buf.take(max_read);
 
+        #[allow(clippy::let_unit_value)]
         let res = ready!(Pin::new(&mut inner.stream).poll_read(cx, &mut limited_buf))?;
 
         let read = limited_buf.filled().len();
@@ -152,14 +153,14 @@ impl<S: AsyncRead + AsyncWrite + Unpin + Send> AsyncRead for TlsPreloginWrapper<
                 let read = ready!(Pin::new(&mut inner.stream).poll_read(cx, header_buf))?;
 
                 if read == 0 {
-                    return Poll::Ready(Ok(PollReadOut::default()));
+                    return Poll::Ready(Ok(Default::default()));
                 }
 
                 inner.header_pos += read;
             }
 
             let header: PacketHeader = Decode::decode(Bytes::copy_from_slice(&inner.header_buf))
-                .map_err(|err| io::Error::new(io::ErrorKind::Other, err))?;
+                .map_err(|err| io::Error::other(err))?;
 
             inner.read_remaining = usize::from(header.length) - HEADER_BYTES;
 

sqlx-core/src/mysql/migrate.rs

@@ -192,7 +192,7 @@ CREATE TABLE IF NOT EXISTS _sqlx_migrations (
                     .map_err(MigrateError::AccessMigrationMetadata)?;
 
             if let Some(checksum) = checksum {
-                if checksum == &*migration.checksum {
+                if checksum == *migration.checksum {
                     Ok(())
                 } else {
                     Err(MigrateError::VersionMismatch(migration.version))

sqlx-core/src/mysql/testing/mod.rs

@@ -45,7 +45,7 @@ impl TestSupport for MySql {
                 .await?;
 
             query("delete from _sqlx_test_databases where db_id = ?")
-                .bind(&db_id)
+                .bind(db_id)
                 .execute(&mut conn)
                 .await?;
 
@@ -127,7 +127,7 @@ async fn test_context(args: &TestArgs) -> Result<TestContext<MySql>, Error> {
     }
 
     query("insert into _sqlx_test_databases(test_path) values (?)")
-        .bind(&args.test_path)
+        .bind(args.test_path)
         .execute(&mut conn)
         .await?;
 
@@ -199,7 +199,8 @@ async fn do_cleanup(conn: &mut MySqlConnection) -> Result<usize, Error> {
         separated.push_bind(db_id);
     }
 
-    drop(separated);
+    // Finalize the separated query builder
+    let _ = separated;
 
     query.push(")").build().execute(&mut *conn).await?;