refactor: streamline clippy checks in CI workflow

- Removed clippy job and integrated checks into existing jobs for core, root, and all targets.
- Added clippy checks for sqlite, postgres, mysql, mariadb, and mssql with specific features.
- Enhanced CI workflow efficiency by consolidating clippy steps.

Author: lovasoa

.github/workflows/sqlx.yml

@@ -14,41 +14,6 @@ jobs:
       - uses: actions/checkout@v4
       - run: cargo fmt --all -- --check
 
-  clippy:
-    name: Clippy
-    runs-on: ubuntu-22.04
-    strategy:
-      matrix:
-        runtime: [async-std, tokio]
-        tls: [native-tls, rustls]
-    steps:
-      - uses: actions/checkout@v4
-      - uses: Swatinem/rust-cache@v2
-      - name: Run clippy for core with all features
-        run: |
-          cargo clippy --manifest-path sqlx-core/Cargo.toml \
-            --no-default-features \
-            --features offline,all-databases,all-types,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }} \
-            -- -D warnings
-        env:
-          RUSTFLAGS: -D warnings
-      - name: Run clippy for root with all features
-        run: |
-          cargo clippy \
-            --no-default-features \
-            --features offline,all-databases,all-types,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros \
-            -- -D warnings
-        env:
-          RUSTFLAGS: -D warnings
-      - name: Run clippy for all targets
-        run: |
-          cargo clippy \
-            --no-default-features \
-            --all-targets \
-            --features offline,all-databases,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }} \
-            -- -D warnings
-        env:
-          RUSTFLAGS: -D warnings
 
   check:
     name: Check
@@ -76,6 +41,25 @@ jobs:
             --no-default-features
             --lib --tests
             --features offline,all-databases,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }}
+      - name: Run clippy for core with all features
+        run: |
+          cargo clippy --manifest-path sqlx-core/Cargo.toml \
+            --no-default-features \
+            --features offline,all-databases,all-types,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }} \
+            -- -D warnings
+      - name: Run clippy for root with all features
+        run: |
+          cargo clippy \
+            --no-default-features \
+            --features offline,all-databases,all-types,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros \
+            -- -D warnings
+      - name: Run clippy for all targets
+        run: |
+          cargo clippy \
+            --no-default-features \
+            --all-targets \
+            --features offline,all-databases,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }} \
+            -- -D warnings
 
   test:
     name: Unit Test
@@ -134,26 +118,6 @@ jobs:
           name: cargo-sqlx-${{ matrix.target }}
           path: ${{ matrix.bin }}
 
-  clippy-per-db:
-    name: Clippy per Database
-    runs-on: ubuntu-22.04
-    strategy:
-      matrix:
-        db: [postgres, mysql, sqlite, mssql]
-        runtime: [tokio]
-        tls: [rustls]
-    needs: clippy
-    steps:
-      - uses: actions/checkout@v4
-      - uses: Swatinem/rust-cache@v2
-      - name: Run clippy for ${{ matrix.db }}
-        run: |
-          cargo clippy \
-            --no-default-features \
-            --features ${{ matrix.db }},all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros,migrate \
-            -- -D warnings
-        env:
-          RUSTFLAGS: -D warnings
 
   sqlite:
     name: SQLite
@@ -167,6 +131,12 @@ jobs:
       - uses: actions/checkout@v4
       - run: mkdir /tmp/sqlite3-lib && wget -O /tmp/sqlite3-lib/ipaddr.so https://github.com/nalgeon/sqlean/releases/download/0.15.2/ipaddr.so
       - uses: Swatinem/rust-cache@v2
+      - name: Run clippy for sqlite
+        run: |
+          cargo clippy \
+            --no-default-features \
+            --features sqlite,all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros,migrate \
+            -- -D warnings
       - run:
           cargo test
             --no-default-features
@@ -210,6 +180,15 @@ jobs:
           args: >
             --features postgres,all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }}
 
+      - name: Run clippy for postgres
+        run: |
+          cargo clippy \
+            --no-default-features \
+            --features postgres,all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros,migrate \
+            -- -D warnings
+        env:
+          RUSTFLAGS: --cfg postgres_${{ matrix.postgres }}
+
       - run: |
           docker compose -f tests/docker-compose.yml run -d -p 5432:5432 --name postgres_${{ matrix.postgres }} postgres_${{ matrix.postgres }}
           docker exec postgres_${{ matrix.postgres }} bash -c "until pg_isready; do sleep 1; done"
@@ -281,6 +260,13 @@ jobs:
           args: >
             --features mysql,all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }}
 
+      - name: Run clippy for mysql
+        run: |
+          cargo clippy \
+            --no-default-features \
+            --features mysql,all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros,migrate \
+            -- -D warnings
+
       - run: docker compose -f tests/docker-compose.yml run -d -p 3306:3306 mysql_${{ matrix.mysql }}
       - run: sleep 60
 
@@ -332,6 +318,13 @@ jobs:
           args: >
             --features mysql,runtime-${{ matrix.runtime }}-${{ matrix.tls }}
 
+      - name: Run clippy for mariadb
+        run: |
+          cargo clippy \
+            --no-default-features \
+            --features mysql,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros,migrate \
+            -- -D warnings
+
       - run: docker compose -f tests/docker-compose.yml run -d -p 3306:3306 mariadb_${{ matrix.mariadb }}
       - run: sleep 30
 
@@ -372,6 +365,13 @@ jobs:
           args: >
             --features mssql,all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }}
 
+      - name: Run clippy for mssql
+        run: |
+          cargo clippy \
+            --no-default-features \
+            --features mssql,all-types,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros,migrate \
+            -- -D warnings
+
       - run: docker compose -f tests/docker-compose.yml run -d -p 1433:1433 mssql_${{ matrix.mssql }}
       - run: sleep 80 # MSSQL takes a "bit" to startup