fix compilation without the all-types feature

Author: lovasoa

.github/workflows/sqlx.yml

@@ -28,15 +28,23 @@ jobs:
           cargo check
             --manifest-path sqlx-core/Cargo.toml
             --no-default-features
+            --all-targets
             --features offline,all-databases,all-types,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }}
         env:
           RUSTFLAGS: -D warnings
 
       - run:
           cargo check
             --no-default-features
+            --all-targets
             --features offline,all-databases,all-types,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros
 
+      - run:
+          cargo check
+            --no-default-features
+            --all-targets
+            --features offline,all-databases,migrate,runtime-${{ matrix.runtime }}-${{ matrix.tls }},macros
+
   test:
     name: Unit Test
     runs-on: ubuntu-22.04

test.sh

@@ -2,10 +2,10 @@
 docker compose -f tests/docker-compose.yml run -it -p 5432:5432 --name postgres_16 postgres_16
 DATABASE_URL="postgres://postgres@localhost:5432/sqlx?sslmode=verify-ca&sslrootcert=./tests/certs/ca.crt&sslcert=./tests/certs/client.crt&sslkey=./tests/keys/client.key" cargo test --features any,postgres,macros,all-types,runtime-actix-rustls -- 
 
-docker compose -f tests/docker-compose.yml run -it -p 1433:1433 --name mssql_2022 mssql_2022
+docker compose -f tests/docker-compose.yml run -it -p 1433:1433 --rm --name mssql_2022 mssql_2022
 DATABASE_URL='mssql://sa:Password123!@localhost/sqlx' cargo test --features any,mssql,macros,all-types,runtime-actix-rustls --
 
 docker compose -f tests/docker-compose.yml run -it -p 3306:3306 --name mysql_8 mysql_8
 DATABASE_URL='mysql://root:password@localhost/sqlx' cargo test --features any,mysql,macros,all-types,runtime-actix-rustls --
 
-DATABASE_URL='sqlite://./tests/sqlite/sqlite.db' cargo test --features any,sqlite,macros,all-types,runtime-actix-rustls --
+DATABASE_URL='sqlite://./tests/sqlite/sqlite.db' cargo test --features any,sqlite,macros,all-types,runtime-actix-rustls --

tests/mssql/macros.rs

@@ -20,69 +20,74 @@ async fn test_query_simple() -> anyhow::Result<()> {
     Ok(())
 }
 
-#[sqlx_macros::test]
-async fn test_query_datetime() -> anyhow::Result<()> {
-    let mut conn = new::<Mssql>().await?;
+#[cfg(feature = "chrono")]
+mod macro_chrono {
+    use super::*;
 
-    // Define the expected NaiveDateTime value
-    let expected_naive_dt = sqlx_oldapi::types::chrono::NaiveDate::from_ymd_opt(2024, 7, 15)
-        .expect("Invalid date")
-        .and_hms_milli_opt(10, 30, 0, 123)
-        .expect("Invalid time");
+    #[sqlx_macros::test]
+    async fn test_query_datetime() -> anyhow::Result<()> {
+        let mut conn = new::<Mssql>().await?;
 
-    // Use DATETIME2(3) for precise millisecond storage in MSSQL.
-    // The query! macro requires a string literal.
-    let record =
-        sqlx_oldapi::query!("SELECT CAST('2024-07-15 10:30:00.123' AS DATETIME2(3)) as dt")
-            .fetch_one(&mut conn)
-            .await?;
+        // Define the expected NaiveDateTime value
+        let expected_naive_dt = sqlx_oldapi::types::chrono::NaiveDate::from_ymd_opt(2024, 7, 15)
+            .expect("Invalid date")
+            .and_hms_milli_opt(10, 30, 0, 123)
+            .expect("Invalid time");
 
-    assert_eq!(record.dt, Some(expected_naive_dt));
+        // Use DATETIME2(3) for precise millisecond storage in MSSQL.
+        // The query! macro requires a string literal.
+        let record =
+            sqlx_oldapi::query!("SELECT CAST('2024-07-15 10:30:00.123' AS DATETIME2(3)) as dt")
+                .fetch_one(&mut conn)
+                .await?;
 
-    Ok(())
-}
+        assert_eq!(record.dt, Some(expected_naive_dt));
 
-#[derive(sqlx_oldapi::FromRow, Debug, Clone, PartialEq)]
-pub struct LogNotificationConfig {
-    pub id: i32,
-    pub config_key: String,
-    pub config_value: String,
-    pub created_on: Option<sqlx_oldapi::types::chrono::NaiveDateTime>,
-    pub last_updated: Option<sqlx_oldapi::types::chrono::NaiveDateTime>,
-}
+        Ok(())
+    }
 
-#[sqlx_macros::test]
-async fn test_query_as_from_issue() -> anyhow::Result<()> {
-    let mut conn = new::<Mssql>().await?;
+    #[derive(sqlx_oldapi::FromRow, Debug, Clone, PartialEq)]
+    pub struct LogNotificationConfig {
+        pub id: i32,
+        pub config_key: String,
+        pub config_value: String,
+        pub created_on: Option<sqlx_oldapi::types::chrono::NaiveDateTime>,
+        pub last_updated: Option<sqlx_oldapi::types::chrono::NaiveDateTime>,
+    }
 
-    let expected_created_on = sqlx_oldapi::types::chrono::NaiveDate::from_ymd_opt(2023, 1, 1)
-        .unwrap()
-        .and_hms_milli_opt(10, 0, 0, 0)
-        .unwrap();
-    let expected_last_updated = sqlx_oldapi::types::chrono::NaiveDate::from_ymd_opt(2023, 1, 2)
-        .unwrap()
-        .and_hms_milli_opt(11, 30, 0, 500)
-        .unwrap();
-
-    let result = sqlx_oldapi::query_as!(
-        LogNotificationConfig,
-        r#"
+    #[sqlx_macros::test]
+    async fn test_query_as_from_issue() -> anyhow::Result<()> {
+        let mut conn = new::<Mssql>().await?;
+
+        let expected_created_on = sqlx_oldapi::types::chrono::NaiveDate::from_ymd_opt(2023, 1, 1)
+            .unwrap()
+            .and_hms_milli_opt(10, 0, 0, 0)
+            .unwrap();
+        let expected_last_updated = sqlx_oldapi::types::chrono::NaiveDate::from_ymd_opt(2023, 1, 2)
+            .unwrap()
+            .and_hms_milli_opt(11, 30, 0, 500)
+            .unwrap();
+
+        let result = sqlx_oldapi::query_as!(
+            LogNotificationConfig,
+            r#"
             SELECT 
                 1 AS id, 
                 'test_key' AS config_key, 
                 'test_value' AS config_value, 
                 CAST('2023-01-01 10:00:00.000' AS DATETIME2(3)) AS created_on, 
                 CAST('2023-01-02 11:30:00.500' AS DATETIME2(3)) AS last_updated
         "#
-    )
-    .fetch_one(&mut conn)
-    .await?;
+        )
+        .fetch_one(&mut conn)
+        .await?;
 
-    assert_eq!(result.id, 1);
-    assert_eq!(result.config_key, "test_key");
-    assert_eq!(result.config_value, "test_value");
-    assert_eq!(result.created_on, Some(expected_created_on));
-    assert_eq!(result.last_updated, Some(expected_last_updated));
+        assert_eq!(result.id, 1);
+        assert_eq!(result.config_key, "test_key");
+        assert_eq!(result.config_value, "test_value");
+        assert_eq!(result.created_on, Some(expected_created_on));
+        assert_eq!(result.last_updated, Some(expected_last_updated));
 
-    Ok(())
+        Ok(())
+    }
 }