fix: resolve remaining simple clippy warnings

- Remove unused mut from variable declaration
- Remove unused lifetime parameter
- Remove legacy numeric constant import
- Simplify boolean expression using De Morgan's law

Author: cursoragent

sqlx-core/src/postgres/connection/executor.rs

@@ -160,7 +160,7 @@ impl PgConnection {
         self.pending_ready_for_query_count += 1;
     }
 
-    async fn get_or_prepare<'a>(
+    async fn get_or_prepare(
         &mut self,
         sql: &str,
         parameters: &[PgTypeInfo],

sqlx-core/src/postgres/message/parse.rs

@@ -1,4 +1,3 @@
-use std::i16;
 
 use crate::io::{BufMutExt, Encode};
 use crate::postgres::io::PgBufMutExt;

sqlx-core/src/postgres/options/ssl_mode.rs

@@ -4,8 +4,7 @@ use std::str::FromStr;
 /// Options for controlling the level of protection provided for PostgreSQL SSL connections.
 ///
 /// It is used by the [`ssl_mode`](super::PgConnectOptions::ssl_mode) method.
-#[derive(Debug, Clone, Copy)]
-#[derive(Default)]
+#[derive(Debug, Clone, Copy, Default)]
 pub enum PgSslMode {
     /// Only try a non-SSL connection.
     Disable,
@@ -30,7 +29,6 @@ pub enum PgSslMode {
     VerifyFull,
 }
 
-
 impl FromStr for PgSslMode {
     type Err = Error;
 

sqlx-core/src/postgres/statement.rs

@@ -53,7 +53,8 @@ impl ColumnIndex<PgStatement<'_>> for &'_ str {
             .metadata
             .column_names
             .get(*self)
-            .ok_or_else(|| Error::ColumnNotFound((*self).into())).copied()
+            .ok_or_else(|| Error::ColumnNotFound((*self).into()))
+            .copied()
     }
 }
 

sqlx-core/src/postgres/types/lquery.rs

@@ -263,7 +263,7 @@ impl FromStr for PgLQueryVariant {
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
         let mut label_length = s.len();
-        let mut rev_iter = s.bytes().rev();
+        let rev_iter = s.bytes().rev();
         let mut modifiers = PgLQueryVariantFlag::default();
 
         for b in rev_iter {

sqlx-core/src/postgres/types/range.rs

@@ -447,7 +447,7 @@ where
                     }
 
                     count += 1;
-                    if !(element.is_empty() && !quoted) {
+                    if !element.is_empty() || quoted {
                         let value = Some(T::decode(PgValueRef {
                             type_info: T::type_info(),
                             format: PgValueFormat::Text,