fix: resolve clippy warnings in pool/inner.rs

- Fix non-binding let on future by spawning close() future
- Replace map_or(false, ...) with is_some_and(...)
- Remove needless borrow in Arc::clone()

Author: cursoragent

sqlx-core/src/lib.rs

@@ -2,72 +2,7 @@
 //! Not intended to be used directly.
 #![recursion_limit = "512"]
 #![warn(future_incompatible, rust_2018_idioms)]
-#![allow(
-    clippy::needless_doctest_main,
-    clippy::type_complexity,
-    dead_code,
-    // Common style warnings that are numerous in the codebase
-    clippy::explicit_auto_deref,
-    clippy::needless_borrow,
-    clippy::needless_return,
-    clippy::redundant_closure,
-    clippy::question_mark,
-    clippy::unnecessary_cast,
-    clippy::from_iter_instead_of_collect,
-    clippy::doc_lazy_continuation,
-    clippy::legacy_numeric_constants,
-    clippy::should_implement_trait,
-    clippy::derivable_impls,
-    clippy::manual_map,
-    clippy::nonminimal_bool,
-    clippy::extra_unused_lifetimes,
-    clippy::deref_by_slicing,
-    clippy::let_underscore_future,
-    clippy::needless_borrowed_reference,
-    clippy::map_clone,
-    clippy::large_enum_variant,
-    clippy::cast_sign_loss,
-    clippy::cast_possible_truncation,
-    clippy::cast_possible_wrap,
-    clippy::cast_precision_loss,
-    clippy::multiple_bound_locations,
-    clippy::unnecessary_map_or,
-    clippy::extra_unused_type_parameters,
-    clippy::iter_cloned_collect,
-    clippy::io_other_error,
-    clippy::needless_borrows_for_generic_args,
-    clippy::is_digit_ascii_radix,
-    clippy::len_zero,
-    clippy::manual_is_multiple_of,
-    clippy::while_let_on_iterator,
-    clippy::wrong_self_convention,
-    clippy::useless_conversion,
-    clippy::ptr_arg,
-    clippy::clone_on_copy,
-    clippy::explicit_counter_loop,
-    clippy::manual_inspect,
-    clippy::len_without_is_empty,
-    clippy::borrow_deref_ref,
-    clippy::get_first,
-    clippy::enum_variant_names,
-    clippy::let_and_return,
-    clippy::needless_option_as_deref,
-    clippy::op_ref,
-    clippy::drop_non_drop,
-    clippy::bool_assert_comparison,
-    clippy::empty_line_after_doc_comments,
-    clippy::single_char_add_str,
-    clippy::let_unit_value,
-    clippy::unit_arg,
-    clippy::result_large_err,
-    clippy::needless_range_loop,
-    clippy::manual_div_ceil,
-    clippy::manual_range_patterns,
-    clippy::never_loop,
-    clippy::module_inception,
-    clippy::unwrap_or_default,
-    clippy::zero_prefixed_literal
-)]
+#![allow(clippy::needless_doctest_main, clippy::type_complexity, dead_code)]
 // Note: Cast warnings are allowed on a case-by-case basis with explicit #[allow(...)]
 // This ensures we're aware of potential issues with numeric conversions
 // See `clippy.toml` at the workspace root

sqlx-core/src/pool/inner.rs

@@ -142,7 +142,11 @@ impl<DB: Database> PoolInner<DB> {
 
                 if parent_close_event.as_mut().poll(cx).is_ready() {
                     // Propagate the parent's close event to the child.
-                    let _ = self.close();
+                    // We can't await here, so we spawn the close future
+                    let close_future = self.close();
+                    sqlx_rt::spawn(async move {
+                        close_future.await;
+                    });
                     return Poll::Ready(Err(Error::PoolClosed));
                 }
 
@@ -197,7 +201,7 @@ impl<DB: Database> PoolInner<DB> {
 
         let Floating { inner: idle, guard } = floating.into_idle();
 
-        if !self.idle_conns.push(idle).is_ok() {
+        if self.idle_conns.push(idle).is_err() {
             panic!("BUG: connection queue overflow in release()");
         }
 
@@ -403,14 +407,14 @@ impl<DB: Database> Drop for PoolInner<DB> {
 fn is_beyond_max_lifetime<DB: Database>(live: &Live<DB>, options: &PoolOptions<DB>) -> bool {
     options
         .max_lifetime
-        .map_or(false, |max| live.created_at.elapsed() > max)
+        .is_some_and(|max| live.created_at.elapsed() > max)
 }
 
 /// Returns `true` if the connection has exceeded `options.idle_timeout` if set, `false` otherwise.
 fn is_beyond_idle_timeout<DB: Database>(idle: &Idle<DB>, options: &PoolOptions<DB>) -> bool {
     options
         .idle_timeout
-        .map_or(false, |timeout| idle.idle_since.elapsed() > timeout)
+        .is_some_and(|timeout| idle.idle_since.elapsed() > timeout)
 }
 
 async fn check_idle_conn<DB: Database>(
@@ -458,7 +462,7 @@ async fn check_idle_conn<DB: Database>(
 }
 
 fn spawn_maintenance_tasks<DB: Database>(pool: &Arc<PoolInner<DB>>) {
-    let pool = Arc::clone(&pool);
+    let pool = Arc::clone(pool);
 
     let period = match (pool.options.max_lifetime, pool.options.idle_timeout) {
         (Some(it), None) | (None, Some(it)) => it,