refactor: Simplify ODBC connection execution and enhance SQL handling

This commit refactors the ODBC connection executor and worker to streamline SQL execution processes. It introduces helper functions for executing SQL commands and collecting results, improving code readability and maintainability. Additionally, it updates the handling of SQL query results to enhance performance and clarity.

Author: lovasoa

sqlx-core/src/column.rs

@@ -55,6 +55,7 @@ impl<T: ?Sized, I: ColumnIndex<T> + ?Sized> ColumnIndex<T> for &'_ I {
     }
 }
 
+#[allow(unused_macros)]
 macro_rules! impl_column_index_for_row {
     ($R:ident) => {
         impl crate::column::ColumnIndex<$R> for usize {
@@ -71,6 +72,7 @@ macro_rules! impl_column_index_for_row {
     };
 }
 
+#[allow(unused_macros)]
 macro_rules! impl_column_index_for_statement {
     ($S:ident) => {
         impl crate::column::ColumnIndex<$S<'_>> for usize {

sqlx-core/src/common/mod.rs

@@ -1,5 +1,6 @@
 mod statement_cache;
 
+#[allow(unused_imports)]
 pub(crate) use statement_cache::StatementCache;
 use std::fmt::{Debug, Formatter};
 use std::ops::{Deref, DerefMut};

sqlx-core/src/lib.rs

@@ -116,5 +116,6 @@ pub mod testing;
 pub use sqlx_rt::test_block_on;
 
 /// sqlx uses ahash for increased performance, at the cost of reduced DoS resistance.
+#[allow(unused_imports)]
 use ahash::AHashMap as HashMap;
 //type HashMap<K, V> = std::collections::HashMap<K, V, ahash::RandomState>;

sqlx-core/src/odbc/connection/executor.rs

@@ -88,8 +88,7 @@ impl<'c> Executor<'c> for &'c mut OdbcConnection {
 fn interpolate_sql_with_odbc_args(sql: &str, args: &[OdbcArgumentValue<'_>]) -> String {
     let mut result = String::with_capacity(sql.len() + args.len() * 8);
     let mut arg_iter = args.iter();
-    let mut chars = sql.chars().peekable();
-    while let Some(ch) = chars.next() {
+    for ch in sql.chars() {
         if ch == '?' {
             if let Some(arg) = arg_iter.next() {
                 match arg {

sqlx-core/src/odbc/connection/worker.rs

@@ -62,7 +62,7 @@ impl Type<Odbc> for String {
     }
 }
 
-impl<'a> Type<Odbc> for &'a str {
+impl Type<Odbc> for &str {
     fn type_info() -> OdbcTypeInfo {
         OdbcTypeInfo {
             name: "TEXT".into(),

sqlx-core/src/odbc/type.rs

@@ -88,6 +88,7 @@ pub trait Statement<'q>: Send + Sync {
         A: IntoArguments<'s, Self::Database>;
 }
 
+#[allow(unused_macros)]
 macro_rules! impl_statement_query {
     ($A:ty) => {
         #[inline]