clippy

Author: lovasoa

sqlx-macros/src/common.rs

@@ -14,11 +14,7 @@ pub(crate) fn resolve_path(path: impl AsRef<Path>, err_span: Span) -> syn::Resul
 
     // requires `proc_macro::SourceFile::path()` to be stable
     // https://github.com/rust-lang/rust/issues/54725
-    if path.is_relative()
-        && !path
-            .parent()
-            .map_or(false, |parent| !parent.as_os_str().is_empty())
-    {
+    if path.is_relative() && path.parent().is_none_or(|p| p.as_os_str().is_empty()) {
         return Err(syn::Error::new(
             err_span,
             "paths relative to the current file's directory are not currently supported",

sqlx-macros/src/lib.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::large_enum_variant)]
 #![cfg_attr(
     not(any(feature = "postgres", feature = "mysql", feature = "offline")),
     allow(dead_code, unused_macros, unused_imports)

sqlx-macros/src/migrate.rs

@@ -19,7 +19,7 @@ impl ToTokens for QuotedMigrationType {
                 quote! { ::sqlx_oldapi::migrate::MigrationType::ReversibleDown }
             }
         };
-        tokens.append_all(ts.into_iter());
+        tokens.append_all(ts);
     }
 }
 
@@ -101,7 +101,7 @@ pub(crate) fn expand_migrator(path: &Path) -> crate::Result<TokenStream> {
             .replace('_', " ")
             .to_owned();
 
-        let sql = fs::read_to_string(&entry.path())?;
+        let sql = fs::read_to_string(entry.path())?;
 
         let checksum = Vec::from(Sha384::digest(sql.as_bytes()).as_slice());
 

sqlx-macros/src/query/mod.rs

@@ -125,6 +125,7 @@ static METADATA: Lazy<Metadata> = Lazy::new(|| {
     }
 });
 
+#[allow(unused_variables)]
 pub fn expand_input(input: QueryMacroInput) -> crate::Result<TokenStream> {
     match &*METADATA {
         #[cfg(not(any(
@@ -135,7 +136,7 @@ pub fn expand_input(input: QueryMacroInput) -> crate::Result<TokenStream> {
         )))]
         Metadata {
             offline: false,
-            database_url: Some(db_url),
+            database_url: Some(_db_url),
             ..
         } => Err(
             "At least one of the features ['postgres', 'mysql', 'mssql', 'sqlite'] must be enabled \
@@ -359,13 +360,9 @@ where
                     }
                 }
 
-                let record_fields = columns.iter().map(
-                    |&output::RustColumn {
-                         ref ident,
-                         ref type_,
-                         ..
-                     }| quote!(#ident: #type_,),
-                );
+                let record_fields = columns
+                    .iter()
+                    .map(|output::RustColumn { ident, type_, .. }| quote!(#ident: #type_,));
 
                 let mut record_tokens = quote! {
                     #[derive(Debug)]