HttpUrl#addPathSegment does not encode square brackets '[', ']

[miloszivkovic]

Was wondering if there are any plans on adding square brackets in list of characters that should be escaped in path segment. RFC3986 says these are allowed only in host part of the URL and I recently had web server returning 400 because "[" in path segment was not escaped.

[yschimke]

This looks like we should be encoding https://stackoverflow.com/questions/40568/are-square-brackets-permitted-in-urls

Mentioned explicitly in https://datatracker.ietf.org/doc/html/rfc3986#section-3.2.2

[swankjesse]

Changing this is potentially breaking, so if we do it we should do it with 5.0.0.

Any fix should retain the unescaped characters if we receive them in addEncodedPath() or toHttpUrl().

[yschimke]

@swankjesse should we do with 5.0?

[swankjesse]

Lets confirm that browsers do it, then do it ourselves in 5.0.