Skip to content

Commit d4c501a

Browse files
committed
Sharing tests, fixtures, and proto generation
We removed a LOT of somewhat golden files and only consume them if some tests now. Proto generation to be used in other tests are now in wire-test-proto-generation, and wire-tests contains proto fixtures and testing modules.
1 parent 5f42d29 commit d4c501a

File tree

713 files changed

+5236
-115276
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

713 files changed

+5236
-115276
lines changed

gen-tests.gradle.kts

Lines changed: 6 additions & 632 deletions
Large diffs are not rendered by default.

settings.gradle.kts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,30 @@ include(":wire-grpc-client")
4949
include(":wire-grpc-mockwebserver")
5050
include(":wire-grpc-tests")
5151
include(":wire-gson-support")
52+
include(":wire-gson-support-test")
5253
include(":wire-java-generator")
5354
include(":wire-kotlin-generator")
5455
include(":wire-moshi-adapter")
56+
include(":wire-moshi-adapter-test")
5557
include(":wire-protoc-compatibility-tests")
5658
include(":wire-reflector")
5759
include(":wire-runtime")
5860
include(":wire-schema")
5961
include(":wire-schema-tests")
6062
include(":wire-swift-generator")
63+
include(":wire-test-proto-generation:grpc")
64+
include(":wire-test-proto-generation:json-java")
65+
include(":wire-test-proto-generation:json-java-compact")
66+
include(":wire-test-proto-generation:json-kotlin")
67+
include(":wire-test-proto-generation:json-kotlin-interop")
6168
include(":wire-test-utils")
62-
include(":wire-tests")
69+
include(":wire-tests:jvm-annotations-interop")
70+
include(":wire-tests:jvm-java-kotlin")
71+
include(":wire-tests:jvm-json-java")
72+
include(":wire-tests:jvm-json-kotlin")
73+
include(":wire-tests:jvm-kotlin-interop")
74+
include(":wire-tests:jvm-kotlin-proto-reader-32")
75+
include(":wire-tests:multiplatform")
6376
if (startParameter.projectProperties.get("swift") != "false") {
6477
include(":wire-runtime-swift")
6578
include(":wire-tests-swift")

wire-compiler/src/test/java/com/squareup/wire/WireCompilerTest.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package com.squareup.wire
1919

2020
import assertk.all
2121
import assertk.assertThat
22-
import assertk.assertions.contains
2322
import assertk.assertions.containsExactly
2423
import assertk.assertions.containsOnly
2524
import assertk.assertions.isEmpty
@@ -29,7 +28,6 @@ import assertk.assertions.isNotNull
2928
import assertk.assertions.isNull
3029
import assertk.assertions.isTrue
3130
import assertk.assertions.prop
32-
import assertk.assertions.size
3331
import com.squareup.wire.kotlin.EnumMode
3432
import com.squareup.wire.kotlin.RpcCallStyle
3533
import com.squareup.wire.kotlin.RpcRole
@@ -103,7 +101,7 @@ class WireCompilerTest {
103101
}
104102
}
105103

106-
@Test // TODO(Benoit) Delete? Nobody wanna maintain such a test
104+
@Test
107105
fun allFlags() {
108106
fileSystem.appendingSink("foo.proto".toPath())
109107
fileSystem.appendingSink("bar.proto".toPath())

wire-grpc-tests/build.gradle.kts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ sourceSets {
4646
val test by getting {
4747
java.srcDir("build/generated/source/proto/test/grpc")
4848
java.srcDir("build/generated/source/proto/test/java")
49-
java.srcDir("src/test/proto-grpc")
5049
}
5150
}
5251

@@ -68,6 +67,7 @@ dependencies {
6867
testImplementation(libs.grpc.stub)
6968
testImplementation(libs.kotlin.test.junit)
7069
testImplementation(libs.protobuf.java)
70+
testImplementation(projects.wireTestProtoGeneration.grpc)
7171
}
7272

7373
val test by tasks.getting(Test::class) {
@@ -76,12 +76,3 @@ val test by tasks.getting(Test::class) {
7676
exceptionFormat = TestExceptionFormat.FULL
7777
}
7878
}
79-
80-
configure<SpotlessExtension> {
81-
kotlin {
82-
targetExclude(
83-
// Generated files.
84-
"src/test/proto-grpc/**/*.kt",
85-
)
86-
}
87-
}

wire-grpc-tests/src/test/proto-grpc/routeguide/Feature.kt

Lines changed: 0 additions & 151 deletions
This file was deleted.

wire-grpc-tests/src/test/proto-grpc/routeguide/FeatureDatabase.kt

Lines changed: 0 additions & 129 deletions
This file was deleted.

0 commit comments

Comments
 (0)