Merge pull request #671 from square/ray/newer-is-always-better-am-i-right

Sacrificing some chickens to the espresso gods

Author: rjrjr

.github/workflows/kotlin.yml

@@ -63,8 +63,9 @@ jobs:
       fail-fast: false
       matrix:
         api-level:
-          - 21
-          - 24
+          - 29
+      # Unclear that older versions actually honor command to disable animation.
+      # Newer versions are reputed to be too slow: https://github.com/ReactiveCircus/android-emulator-runner/issues/222
     steps:
       - uses: actions/checkout@v2
       - name: set up JDK 11.0.7

buildSrc/src/main/java/Dependencies.kt

@@ -52,7 +52,6 @@ object Dependencies {
   const val cycler = "com.squareup.cycler:cycler:0.1.9"
 
   // Required for Dungeon Crawler sample.
-  const val desugar_jdk_libs = "com.android.tools:desugar_jdk_libs:1.1.5"
   const val leakcanary = "com.squareup.leakcanary:leakcanary-android:2.8.1"
   const val radiography = "com.squareup.radiography:radiography:2.4.0"
   const val rxandroid2 = "io.reactivex.rxjava2:rxandroid:2.1.1"

samples/dungeon/app/build.gradle.kts

@@ -13,17 +13,9 @@ android {
 
     testInstrumentationRunner = "com.squareup.sample.dungeon.DungeonTestRunner"
   }
-
-  compileOptions {
-    // Required for SnakeYAML.
-    isCoreLibraryDesugaringEnabled = true
-  }
 }
 
 dependencies {
-  // Required for SnakeYAML.
-  "coreLibraryDesugaring"(Dependencies.desugar_jdk_libs)
-
   debugImplementation(Dependencies.leakcanary)
 
   implementation(project(":samples:dungeon:common"))