Skip to content

Commit b7fd015

Browse files
committed
Final fixes for PR comments
1 parent 1beba35 commit b7fd015

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/App.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ import androidx.compose.runtime.setValue
1010
import androidx.compose.ui.Alignment
1111
import androidx.compose.ui.Modifier
1212
import com.squareup.workflow1.traceviewer.model.Node
13+
import com.squareup.workflow1.traceviewer.ui.FrameSelectTab
1314
import com.squareup.workflow1.traceviewer.ui.RenderDiagram
1415
import com.squareup.workflow1.traceviewer.ui.RightInfoPanel
15-
import com.squareup.workflow1.traceviewer.ui.StateSelectTab
1616
import com.squareup.workflow1.traceviewer.util.SandboxBackground
1717
import com.squareup.workflow1.traceviewer.util.UploadFile
1818
import io.github.vinceglb.filekit.PlatformFile
@@ -44,7 +44,7 @@ public fun App(
4444
}
4545
}
4646

47-
StateSelectTab(
47+
FrameSelectTab(
4848
frames = workflowFrames,
4949
currentIndex = frameIndex,
5050
onIndexChange = { frameIndex = it },

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/ui/FrameSelectTab.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import com.squareup.workflow1.traceviewer.model.Node
1818
* A trace tab selector that allows devs to switch between different states within the provided trace.
1919
*/
2020
@Composable
21-
public fun StateSelectTab(
21+
public fun FrameSelectTab(
2222
frames: List<Node>,
2323
currentIndex: Int,
2424
onIndexChange: (Int) -> Unit,

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/ui/WorkflowTree.kt

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,17 @@ public fun RenderDiagram(
4343
LaunchedEffect(traceFile) {
4444
val parseResult = parseTrace(traceFile)
4545

46-
if (parseResult is ParseResult.Failure) {
47-
error = parseResult.error
48-
return@LaunchedEffect
46+
when (parseResult) {
47+
is ParseResult.Failure -> {
48+
error = parseResult.error
49+
}
50+
is ParseResult.Success -> {
51+
val parsedFrames = parseResult.trace ?: emptyList()
52+
frames = parsedFrames
53+
onFileParse(parsedFrames)
54+
isLoading = false
55+
}
4956
}
50-
51-
val parsedFrames = (parseResult as ParseResult.Success).trace ?: emptyList()
52-
frames = parsedFrames
53-
onFileParse(parsedFrames)
54-
isLoading = false
5557
}
5658

5759
if (error != null) {

0 commit comments

Comments
 (0)