Skip to content

Commit cd8b4ab

Browse files
committed
Clean up compose violations
1 parent fff11db commit cd8b4ab

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/App.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@ internal fun App(
7171
) {
7272
// if there is not a file selected and trace mode is live, then don't render anything.
7373
val readyForFileTrace = traceMode is TraceMode.File && selectedTraceFile != null
74-
if (readyForFileTrace || traceMode is TraceMode.Live) {
74+
val readyForLiveTrace = traceMode is TraceMode.Live
75+
76+
if (readyForFileTrace || readyForLiveTrace) {
7577
RenderTrace(
7678
traceSource = traceMode,
7779
frameInd = frameIndex,

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/ui/WorkflowTree.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import com.squareup.workflow1.traceviewer.util.ParseResult
2828
import com.squareup.workflow1.traceviewer.util.createMoshiAdapter
2929
import com.squareup.workflow1.traceviewer.util.parseFileTrace
3030
import com.squareup.workflow1.traceviewer.util.parseLiveTrace
31-
import io.github.vinceglb.filekit.dialogs.FileKitMode.Single.parseResult
3231
import kotlinx.coroutines.Dispatchers
3332
import kotlinx.coroutines.withContext
3433

@@ -175,7 +174,6 @@ private fun DrawNode(
175174
modifier = Modifier
176175
.background(if (isAffected) Color.Green else Color.Transparent)
177176
.clickable {
178-
// Selecting a node will bubble back up to the main view to handle the selection
179177
onNodeSelect(node, previousNode)
180178
}
181179
.padding(10.dp)

workflow-trace-viewer/src/jvmMain/kotlin/com/squareup/workflow1/traceviewer/util/JsonParser.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ internal suspend fun parseFileTrace(
4848
return ParseResult.Success(
4949
trace = parsedFrames,
5050
trees = frameTrees,
51-
affectedNodes = parsedRenderPasses)
51+
affectedNodes = parsedRenderPasses
52+
)
5253
}
5354

5455
/**

0 commit comments

Comments
 (0)