Skip to content

Commit ea088d9

Browse files
committed
For unified macOS bundles, add workaround regarding MainMenu.nib. See #36
1 parent fb6d8aa commit ea088d9

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

helpers_bundles.sh

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -185,15 +185,16 @@ copy_resources() {
185185
}
186186

187187
# Make a fat binary from a pair of VMs in
188-
# build.macos64{x64,ARMv8}/virtend.cog.spur/Virtend*.app
189-
# To choose the oldest nib the oldest deployment target (x86_64) should be last
188+
# building/macos64{x64,ARMv8}/squeak.cog.spur/Squeak*.app
189+
# To choose the oldest *.nib, meaning the oldest deployment
190+
# target (x86_64) should be the second argument
190191
create_unified_vm_macOS() {
191192
local MISMATCHINGNIBS=
192193
local MISMATCHINGPLISTS=
193194

194195
readonly O="$1"
195-
readonly A="$2"
196-
readonly B="$3"
196+
readonly A="$2" # ARMv8
197+
readonly B="$3" # x64
197198

198199
if [ ! -d "$A" ]; then
199200
echo "$A does not exist; aborting"
@@ -215,14 +216,14 @@ create_unified_vm_macOS() {
215216
# echo ln -s `readlink "$A/$f"` "$O/$f"
216217
elif [ ! -f "$A/$f" ]; then
217218
echo "$A/$f does not exist; how come?"
218-
elif [ ! -f "$B/$f" ]; then
219+
elif [ "$f" != *"MainMenu.nib" ] && [ ! -f "$B/$f" ]; then
219220
echo "$B/$f does not exist; how come?"
220221
else
221222
case `file -b "$A/$f"` in
222223
Mach-O*)
223224
lipo -create -output "$O/$f" "$A/$f" "$B/$f";;
224225
*)
225-
if cmp -s "$A/$f" "$B/$f"; then
226+
if [ "$f" == *"MainMenu.nib" ] || [ cmp -s "$A/$f" "$B/$f" ]; then
226227
cp "$A/$f" "$O/$f"
227228
else
228229
echo "EXCLUDING $f because it differs"

0 commit comments

Comments
 (0)