Incorrect language code for Korean?

[ericswpark]

Hi, the documentation of mkdocs-material states kr is the language code of Korean, but Django and the ISO 639-1 standard says ko is the language code of Korean, and kr is the language code for Kanuri. Even the documentation says to follow ISO 639-1, which seems a bit contradictory. Can this be changed?

[squidfunk]

You're right, the code is wrong. We can and should change it and maintain backward compatibility until the next major release. A PR is appreciated, if you want to step up.

[yeemh]

@squidfunk
Hi, I'm using two plugins (mkdocs-static-i18n, mkdocs-git-revision-date-localized-plugin) and now I'm struggling with this issue. Because mkdocs-git-revision-date-localized-plugin uses ISO code (ko), but when I use ko for default language then below error occurs.

Traceback (most recent call last):
  File "/usr/local/bin/mkdocs", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/__main__.py", line 215, in gh_deploy_command
    build.build(cfg, dirty=not clean)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/build.py", line 306, in build
    _build_theme_template(template, env, files, config, nav)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/build.py", line 111, in _build_theme_template
    output = _build_template(template_name, template, files, config, nav)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/build.py", line 90, in _build_template
    output = template.render(context)
  File "/usr/local/lib/python3.9/site-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/usr/local/lib/python3.9/site-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "/usr/local/lib/python3.9/site-packages/material/404.html", line 4, in top-level template code
    {% extends "main.html" %}
  File "/usr/local/lib/python3.9/site-packages/material/main.html", line 4, in top-level template code
    {% extends "base.html" %}
  File "/usr/local/lib/python3.9/site-packages/material/base.html", line 4, in top-level template code
    {% import "partials/language.html" as lang with context %}
  File "/usr/local/lib/python3.9/site-packages/jinja2/environment.py", line 1405, in make_module
    return TemplateModule(self, ctx)
  File "/usr/local/lib/python3.9/site-packages/jinja2/environment.py", line [153](https://github.com/yeemh/docs_test/runs/7496729047?check_suite_focus=true#step:4:154)5, in __init__
    body_stream = list(template.root_render_func(context))  # type: ignore
  File "/usr/local/lib/python3.9/site-packages/material/partials/language.html", line 4, in top-level template code
    {% import "partials/languages/" ~ config.theme.language ~ ".html" as lang %}
  File "/usr/local/lib/python3.9/site-packages/jinja2/loaders.py", line 218, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: partials/languages/ko.html

So when will this change be applied?

[squidfunk]

You can create an issue and I will look into it when I'm back from vacation. Note that we need to maintain backward compatibility until the next major version, so we need to forward the old language code to the new one.

[squidfunk]

The Korean language code was changed to ko in #4628. The fix will be released with the next major version, v9.