Feedback widget with navigation.instant

[wandri]

Hi, thanks for the work on this repository, it's awesome.

I'm strugling to find a nice way to implement a custom feedback widget with the navigation.instant parameter. Because in my implementation, it's displayed in the first page but after a navigation, it's not anymore displayed.

In the google analytics script,

• It uses DOMContentLoaded but it's only invoked once at the beginning.
• It uses location$.subscribe but it is invoked before the load of the page in XHR.

Currently I'm doing a hack wich is:

if (typeof location$ !== "undefined") {
  location$.subscribe(function () {
    setTimeout(() => {
      generateFeedback()
    }, 400)
  })
}

But it's an hack. And if the XHR call makes more than 400ms, it won't work.

I'm probably missing something. Do you know if there is a nicer and better way ?

[squidfunk]

The location$ emits as soon as navigation is initiated. You probably want to wait for the document to be loaded:

document$.subscribe(() => {
  console.log("page loaded via instant loading")
})

[wandri]

Thanks @squidfunk , it works well!