4.30.1-insiders: The Giscus client is downloaded automatically, although it is excluded from external assets (privacy plugin).

[white-gorilla]

I have integrated today, with version 4.28.1, the comment system.
I had previously activated the privacy plugin, without any particular configuration, so that it would automatically download the external assets and set the attributes on the external links.

The giscus widget systematically returned a 404 on loading.
@laymonage told me that it was due to the fact that I was uploading the script and hosting it on my site.

So I excluded this dependency as indicated in the documentation.
The Giscus client worked with this change.

I upgraded the Insiders version to 4.30.1, deleted the cache, and now the comment system is returning a 404 again.
When I look at the build log, I see INFO - Downloading external file: https://giscus.app/client.js although this is excluded.

Is this a regression?

[squidfunk]

Ah, that looks like a regression! I'll look into it.

Edit: yes, it was a regression. Fixed in 0dde44880 and released as part of 9.0.12+insiders-4.30.2. If you find other problems, please report them. The privacy plugin was completely rewritten in 4.30 and will now download all assets concurrently – it's twice as fast on our own documentation, dropping from 28s to 11s on the initial build. It can now also be combined with the built-in optimize plugin.