Privacy Plugin

[maybenikhil]

Hello, I am trying to deploy the privacy plugin for https://www.expresslrs.org. However, when I build I get the following error:

ERROR   -  Error reading page 'hardware/fan-mod.md':
Traceback (most recent call last):
  File "/mnt/c/Users/frost/TEMP/venv/bin/mkdocs", line 8, in <module>
    sys.exit(cli())
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/mkdocs/__main__.py", line 286, in build_command
    build.build(cfg, dirty=not clean)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/mkdocs/commands/build.py", line 322, in build
    _populate_page(file.page, config, files, dirty)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/mkdocs/commands/build.py", line 179, in _populate_page
    page.content = config.plugins.on_page_content(
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/mkdocs/plugins.py", line 578, in on_page_content
    return self.run_event('page_content', html, page=page, config=config, files=files)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/mkdocs/plugins.py", line 507, in run_event
    result = method(item, **kwargs)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/material/plugins/privacy/plugin.py", line 153, in on_page_content
    el = self._parse_fragment(match)
  File "/mnt/c/Users/frost/TEMP/venv/lib/python3.10/site-packages/material/plugins/privacy/plugin.py", line 300, in _parse_fragment
    assert isinstance(parser.result, Element)
AssertionError

I can't quite tell what this is actually from. This is the file that is throwing that error: https://github.com/ExpressLRS/Docs/blob/master/docs/hardware/fan-mod.md

Thank you!

[alexvoss]

You could help us investigate the problem by creating a minimal reproduction? I am happy to look at it and help. Also, sometimes producing a reproduction narrows the problem down so much that its origin becomes obvious.

[maybenikhil]

9.5.15+insiders.4.53.3-privacy-error.zip
Here's a minimal reproduction. Seems like it's on our sides downloading something from github user content, but given that image renders and works fine i'm unsure if it could actually count as a bug on your guys' side or really just on us. Thank you!

[squidfunk]

The HTML is invalid:

... 
<figure markdown>
<img class="center-img" src="https://raw.githubusercontent.com/ExpressLRS/ExpressLRS-Hardware/master/STL/R9M-Fan-Mod-Case/view-top.png" data-canonical-src="https://raw.githubusercontent.com/ExpressLRS/ExpressLRS-Hardware/master/STL/R9M-Fan-Mod-Case/view-top.png" width="40%>
</figure>

There's a " missing after 40%. Unfortunately, we're locked to an HTML4 parser which does not gracefully recover from errors like that, but I've added a check that catches the invalid parsing run and prints it, so that debugging becomes easier in 29cf44b.

[squidfunk]

Output is now:

INFO    -  Cleaning site directory
ERROR   -  Error reading page 'hardware/fan-mod.md':
ERROR   -  Could not parse due to possible syntax error in HTML:

           <img class="center-img" src="https://raw.githubusercontent.com/ExpressLRS/ExpressLRS-Hardware/master/STL/R9M-Fan-Mod-Case/view-top.png"
           data-canonical-src="https://raw.githubusercontent.com/ExpressLRS/ExpressLRS-Hardware/master/STL/R9M-Fan-Mod-Case/view-top.png" width="40%>

Aborted with a BuildError!

[squidfunk]

Released as part of 9.5.16.