fix rootMargin definition

maerzhase · maerzhase · commit 32fe67bb0285 · 2020-08-19T16:43:05.000+01:00
diff --git a/src/Step.js b/src/Step.js
@@ -2,7 +2,7 @@ import React from 'react';
 import useIntersectionObserver from './useIntersectionObserver';
 
 const useRootMargin = offset => {
-  return `${offset * 100}% 0px -${100 - offset * 100}% 0px`;
+  return `-${offset * 100}% 0px -${100 - offset * 100}% 0px`;
 }
 
 const Step = props => {
@@ -56,7 +56,7 @@ const Step = props => {
         document.removeEventListener('scroll', handleScroll);
       };
     }
-  }, [entry, rootMargin]);
+  }, [entry]);
 
   return React.cloneElement(React.Children.only(children), {
     'data-react-scrollama-id': scrollamaId,

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import React from 'react';`
`2`	`2`	`import useIntersectionObserver from './useIntersectionObserver';`
`3`	`3`
`4`	`4`	`const useRootMargin = offset => {`
`5`		- return `${offset * 100}% 0px -${100 - offset * 100}% 0px`;
	`5`	+ return `-${offset * 100}% 0px -${100 - offset * 100}% 0px`;
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`const Step = props => {`
`@@ -56,7 +56,7 @@ const Step = props => {`
`56`	`56`	`document.removeEventListener('scroll', handleScroll);`
`57`	`57`	`};`
`58`	`58`	`}`
`59`		`- }, [entry, rootMargin]);`
	`59`	`+ }, [entry]);`
`60`	`60`
`61`	`61`	`return React.cloneElement(React.Children.only(children), {`
`62`	`62`	`'data-react-scrollama-id': scrollamaId,`