Skip to content

Commit 03256dd

Browse files
committed
Merge branch 'feature/ghactions-turn-on-error-reporting' of https://github.com/jrfnl/PHP_CodeSniffer
2 parents f76ee80 + 357ed01 commit 03256dd

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,14 @@ jobs:
5151
- name: Setup ini config
5252
id: set_ini
5353
run: |
54-
# On stable PHPCS versions, allow for PHP deprecation notices.
55-
# Unit tests don't need to fail on those for stable releases where those issues won't get fixed anymore.
56-
# Also set the "short_open_tag" ini to make sure specific conditions are tested.
54+
# Set the "short_open_tag" ini to make sure specific conditions are tested.
55+
# Also turn on error_reporting to ensure all notices are shown.
5756
if [[ ${{ matrix.custom_ini }} == true && "${{ matrix.php }}" == '5.5' ]]; then
58-
echo '::set-output name=PHP_INI::phar.readonly=Off, date.timezone=Australia/Sydney, short_open_tag=On, asp_tags=On'
57+
echo '::set-output name=PHP_INI::phar.readonly=Off, error_reporting=E_ALL, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On, asp_tags=On'
5958
elif [[ ${{ matrix.custom_ini }} == true && "${{ matrix.php }}" == '7.0' ]]; then
60-
echo '::set-output name=PHP_INI::phar.readonly=Off, date.timezone=Australia/Sydney, short_open_tag=On'
59+
echo '::set-output name=PHP_INI::phar.readonly=Off, error_reporting=E_ALL, display_errors=On, date.timezone=Australia/Sydney, short_open_tag=On'
6160
else
62-
echo '::set-output name=PHP_INI::phar.readonly=Off'
61+
echo '::set-output name=PHP_INI::phar.readonly=Off, error_reporting=E_ALL, display_errors=On'
6362
fi
6463
6564
- name: Install PHP

0 commit comments

Comments
 (0)