Explicitely compare isset with true

ghunti · ghunti · commit 32b59b99f205 · 2017-04-25T08:20:32.000+01:00
diff --git a/CodeSniffer/Standards/Generic/Sniffs/PHP/DisallowShortOpenTagSniff.php b/CodeSniffer/Standards/Generic/Sniffs/PHP/DisallowShortOpenTagSniff.php
@@ -73,7 +73,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
             $fix   = $phpcsFile->addFixableError($error, $stackPtr, 'Found', $data);
             if ($fix === true) {
                 $correctOpening = '<?php';
-                if (isset($tokens[$stackPtr + 1]) && $tokens[$stackPtr + 1]['code'] !== T_WHITESPACE) {
+                if (isset($tokens[$stackPtr + 1]) === true && $tokens[$stackPtr + 1]['code'] !== T_WHITESPACE) {
                     // Avoid creation of invalid open tags like <?phpecho if the original was <?echo
                     $correctOpening .= ' ';
                 }

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)`
`73`	`73`	`$fix = $phpcsFile->addFixableError($error, $stackPtr, 'Found', $data);`
`74`	`74`	`if ($fix === true) {`
`75`	`75`	`$correctOpening = '<?php';`
`76`		`- if (isset($tokens[$stackPtr + 1]) && $tokens[$stackPtr + 1]['code'] !== T_WHITESPACE) {`
	`76`	`+ if (isset($tokens[$stackPtr + 1]) === true && $tokens[$stackPtr + 1]['code'] !== T_WHITESPACE) {`
`77`	`77`	`// Avoid creation of invalid open tags like <?phpecho if the original was <?echo`
`78`	`78`	`$correctOpening .= ' ';`
`79`	`79`	`}`