Skip to content

Commit 377a467

Browse files
committed
PHP 8.1: fix deprecation notice [2]
The `Fixer::generateDiff()` method calls the `shell_exec()` method to retrieve the `diff` between two files. In the unit tests, this is used to compare the expected content in a `.fixed` file with the generate fixed file contents. If the expected content matches the generated content, the diff command will produce no output and `shell_exec()` will return `null`. Ref: https://www.php.net/manual/en/function.shell-exec.php This result is subsequently passed to `explode()` as the second parameter, but `explode()` only excepts strings as the second parameter. Ref: https://www.php.net/manual/en/function.explode As of PHP 8.1, this will generate a deprecation notice `explode(): Passing null to parameter #2 ($string) of type string is deprecated`. Discovered while testing an external standard against PHPCS `master` on PHP 8.1. Fixed now.
1 parent a4272b6 commit 377a467

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/Fixer.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,10 @@ public function generateDiff($filePath=null, $colors=true)
255255
unlink($tempName);
256256
}
257257

258+
if ($diff === null) {
259+
return '';
260+
}
261+
258262
if ($colors === false) {
259263
return $diff;
260264
}

0 commit comments

Comments
 (0)