Fixed bug #1769 : Custom define function triggers a warning about declaring new symbols

Author: gsherwood

package.xml

@@ -139,6 +139,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Fixed bug #1761 : Generic.WhiteSpace.ScopeIndent error on multi-line function call with static closure argument
   - Fixed bug #1762 : Generic.WhiteSpace.Disallow[Space/Tab]Indent not inspecting content before open tag
     -- Thanks to Juliette Reinders Folmer for the patch
+  - Fixed bug #1769 : Custom "define" function triggers a warning about declaring new symbols
  </notes>
  <contents>
   <dir name="/">

src/Standards/PSR1/Sniffs/Files/SideEffectsSniff.php

@@ -178,7 +178,9 @@ private function searchForConflict($phpcsFile, $start, $end, $tokens)
                 && strtolower($tokens[$i]['content']) === 'define'
             ) {
                 $prev = $phpcsFile->findPrevious(T_WHITESPACE, ($i - 1), null, true);
-                if ($tokens[$prev]['code'] !== T_OBJECT_OPERATOR) {
+                if ($tokens[$prev]['code'] !== T_OBJECT_OPERATOR
+                    && $tokens[$prev]['code'] !== T_DOUBLE_COLON
+                ) {
                     if ($firstSymbol === null) {
                         $firstSymbol = $i;
                     }

src/Standards/PSR1/Tests/Files/SideEffectsUnitTest.2.inc

@@ -12,6 +12,7 @@ $var = myFunction();
 print_r($var);
 echo $object->define();
 echo $object -> define();
+Foo::define();
 
 $c = new class extends Something{