Generic/ClosingPHPTag: also check for short open echo tag

Includes unit tests.

Author: jrfnl

package.xml

@@ -664,7 +664,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
         <file baseinstalldir="PHP/CodeSniffer" name="CharacterBeforePHPOpeningTagUnitTest.2.inc" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="CharacterBeforePHPOpeningTagUnitTest.3.inc" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="CharacterBeforePHPOpeningTagUnitTest.php" role="test" />
-        <file baseinstalldir="PHP/CodeSniffer" name="ClosingPHPTagUnitTest.inc" role="test" />
+        <file baseinstalldir="PHP/CodeSniffer" name="ClosingPHPTagUnitTest.1.inc" role="test" />
+        <file baseinstalldir="PHP/CodeSniffer" name="ClosingPHPTagUnitTest.2.inc" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="ClosingPHPTagUnitTest.php" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="DeprecatedFunctionsUnitTest.inc" role="test" />
         <file baseinstalldir="PHP/CodeSniffer" name="DeprecatedFunctionsUnitTest.php" role="test" />

src/Standards/Generic/Sniffs/PHP/ClosingPHPTagSniff.php

@@ -23,7 +23,10 @@ class ClosingPHPTagSniff implements Sniff
      */
     public function register()
     {
-        return [T_OPEN_TAG];
+        return [
+            T_OPEN_TAG,
+            T_OPEN_TAG_WITH_ECHO,
+        ];
 
     }//end register()
 

src/Standards/Generic/Tests/PHP/ClosingPHPTagUnitTest.inc renamed to src/Standards/Generic/Tests/PHP/ClosingPHPTagUnitTest.1.inc

@@ -0,0 +1,5 @@
+<?= 'foo'; ?>
+<b>Bold text</b>
+<?= 'bar'; ?>
+<i>Italic text</i>
+<?= 'baz';

src/Standards/Generic/Tests/PHP/ClosingPHPTagUnitTest.2.inc

@@ -21,11 +21,22 @@ class ClosingPHPTagUnitTest extends AbstractSniffUnitTest
      * The key of the array should represent the line number and the value
      * should represent the number of errors that should occur on that line.
      *
+     * @param string $testFile The name of the file being tested.
+     *
      * @return array<int, int>
      */
-    public function getErrorList()
+    public function getErrorList($testFile='')
     {
-        return [9 => 1];
+        switch ($testFile) {
+        case 'ClosingPHPTagUnitTest.1.inc':
+            return [9 => 1];
+        case 'ClosingPHPTagUnitTest.2.inc':
+            return [5 => 1];
+            break;
+        default:
+            return [];
+            break;
+        }
 
     }//end getErrorList()