Merge branch 'pulls/test-is-bs' of https://github.com/dhensby/PHP_CodeSniffer

Author: gsherwood

src/Standards/PSR2/Sniffs/Namespaces/UseDeclarationSniff.php

@@ -142,7 +142,31 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        $next = $phpcsFile->findNext(Tokens::$emptyTokens, ($end + 1), null, true);
+        // Find either the start of the next line or the beginning of the next statement,
+        // whichever comes first.
+        for ($end = ++$end; $end < $phpcsFile->numTokens; $end++) {
+            if (isset(Tokens::$emptyTokens[$tokens[$end]['code']]) === false) {
+                break;
+            }
+
+            if ($tokens[$end]['column'] === 1) {
+                // Reached the next line.
+                break;
+            }
+        }
+
+        --$end;
+
+        if (($tokens[$end]['code'] === T_COMMENT
+            || isset(Tokens::$phpcsCommentTokens[$tokens[$end]['code']]) === true)
+            && substr($tokens[$end]['content'], 0, 2) === '/*'
+            && substr($tokens[$end]['content'], -2) !== '*/'
+        ) {
+            // Multi-line block comments are not allowed as trailing comment after a use statement.
+            --$end;
+        }
+
+        $next = $phpcsFile->findNext(T_WHITESPACE, ($end + 1), null, true);
 
         if ($next === false || $tokens[$next]['code'] === T_CLOSE_TAG) {
             return;

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.10.inc

@@ -0,0 +1,8 @@
+<?php
+use Foo\Bar; // trailing comment
+// This should fail.
+
+class Baz
+{
+
+}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.10.inc.fixed

@@ -0,0 +1,9 @@
+<?php
+use Foo\Bar; // trailing comment
+
+// This should fail.
+
+class Baz
+{
+
+}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.11.inc

@@ -0,0 +1,2 @@
+<?php
+use Foo\Bar; class Baz {}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.11.inc.fixed

@@ -0,0 +1,4 @@
+<?php
+use Foo\Bar; 
+
+class Baz {}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.12.inc

@@ -0,0 +1,9 @@
+<?php
+use Foo\Bar; /*
+ * This multi-line comment shouldn't be allowed here.
+ */
+
+class Baz
+{
+
+}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.12.inc.fixed

@@ -0,0 +1,11 @@
+<?php
+use Foo\Bar; 
+
+/*
+ * This multi-line comment shouldn't be allowed here.
+ */
+
+class Baz
+{
+
+}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.13.inc

@@ -0,0 +1,10 @@
+<?php
+use Foo\Bar; // trailing comment
+/*
+ * This multi-line comment shouldn't be allowed here.
+ */
+
+class Baz
+{
+
+}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.13.inc.fixed

@@ -0,0 +1,11 @@
+<?php
+use Foo\Bar; // trailing comment
+
+/*
+ * This multi-line comment shouldn't be allowed here.
+ */
+
+class Baz
+{
+
+}

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.14.inc

@@ -0,0 +1,8 @@
+<?php
+use Foo\Bar; // trailing comment
+/* phpcs:ignore Standard.Category.Sniff -- for reasons */
+
+class Baz
+{
+
+}